From: "Ludovic Courtès" <ludo@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 63860-done@debbugs.gnu.org,
Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: bug#63860: [PATCH] Shepherd: Add Bash completion file.
Date: Mon, 05 Jun 2023 14:03:32 +0200 [thread overview]
Message-ID: <873536jeuj.fsf_-_@gnu.org> (raw)
In-Reply-To: <20230604085716.31735-1-go.wigust@gmail.com> (Oleg Pykhalov's message of "Sun, 4 Jun 2023 11:57:16 +0300")
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
Hello,
Oleg Pykhalov <go.wigust@gmail.com> skribis:
> * etc/completion/bash/herd: New file.
> * Makefile.am (dist_bashcompletion_DATA): New variable.
> * configure.ac: Add --with-bash-completion-dir.
Excellent! Applied with the changes below.
Thank you & thanks Liliana for reviewing!
Ludo’.
[-- Attachment #2: Type: text/x-patch, Size: 1062 bytes --]
diff --git a/NEWS b/NEWS
index d6c2fc0..b644adb 100644
--- a/NEWS
+++ b/NEWS
@@ -13,6 +13,11 @@ Please send Shepherd bug reports to bug-guix@gnu.org.
* Changes in 0.10.2
+** New Bash completion
+
+A Bash completion file is now installed, providing tab completion for the
+‘herd’ command.
+
** ‘herd’ shows a hint when the service and action are likely swapped
The hint is printed for instance when typing ‘herd foobar start’.
diff --git a/etc/completion/bash/herd b/etc/completion/bash/herd
index f006b86..74e7a24 100644
--- a/etc/completion/bash/herd
+++ b/etc/completion/bash/herd
@@ -44,8 +44,8 @@ _herd_complete_3()
local command="${COMP_WORDS[2]}"
case "$command" in
guix-daemon)
- complitions="on off"
- mapfile -t COMPREPLY < <(compgen -W "$complitions" -- "${COMP_WORDS[$COMP_CWORD]}")
+ completions="on off"
+ mapfile -t COMPREPLY < <(compgen -W "$completions" -- "${COMP_WORDS[$COMP_CWORD]}")
;;
*)
;;
prev parent reply other threads:[~2023-06-05 12:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 22:19 [bug#63860] [PATCH] Shepherd: Add Bash completion file Oleg Pykhalov
2023-06-02 22:21 ` [bug#63860] [PATCH] " Oleg Pykhalov
2023-06-03 9:37 ` [bug#63860] [PATCH v2] " Oleg Pykhalov
2023-06-03 9:41 ` [bug#63860] [PATCH] Shepherd: " Oleg Pykhalov
2023-06-03 18:20 ` [bug#63860] [PATCH v2] " Liliana Marie Prikler
2023-06-03 19:28 ` Oleg Pykhalov
2023-06-03 21:42 ` Liliana Marie Prikler
2023-06-04 8:57 ` [bug#63860] [PATCH v3] " Oleg Pykhalov
2023-06-05 12:03 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873536jeuj.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=63860-done@debbugs.gnu.org \
--cc=go.wigust@gmail.com \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.