From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "ShinyZero0" <shinyzero0@tilde.club>
Cc: 65197@debbugs.gnu.org
Subject: [bug#65197] add offpunk
Date: Wed, 06 Sep 2023 01:00:28 -0400 [thread overview]
Message-ID: <8734zr99qr.fsf@gmail.com> (raw)
In-Reply-To: <CUOPJROOM6ZF.35KPDF9MJI7RB@Void> (shinyzero0@tilde.club's message of "Thu, 10 Aug 2023 11:06:20 +0300")
Hi,
This series look good for the most part. It's just missing GNU
ChangeLog style commits message. You can check other commits or read
'info (standards) ChangeLog' from the 'standards' package to get
familiar with it.
Could you send a v2 with the changelog added?
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-09-06 5:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 8:06 [bug#65197] add offpunk ShinyZero0
2023-08-10 10:47 ` [bug#65197] [PATCH] fix formatting issues, remove unnecessary module import ShinyZero0
2023-08-12 22:21 ` [bug#65197] [PATCH] install manpage ShinyZero0
2023-08-15 22:44 ` [bug#65197] [PATCH] gnu: Add offpunk ShinyZero0
2023-09-06 5:00 ` Maxim Cournoyer [this message]
2023-09-18 16:18 ` [bug#65197] add offpunk ShinyZero0
2023-09-18 16:38 ` ShinyZero0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734zr99qr.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=65197@debbugs.gnu.org \
--cc=shinyzero0@tilde.club \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.