From: Tomas Volf <~@wolfsden.cz>
To: Skyler Ferris <skyvine@protonmail.com>
Cc: 69131@debbugs.gnu.org
Subject: [bug#69131] [PATCH 2/2] gnu: podman: Update to 4.9.3.
Date: Fri, 16 Feb 2024 22:16:47 +0100 [thread overview]
Message-ID: <8734tsyurk.fsf@wolfsden.cz> (raw)
In-Reply-To: <67f55915-ec45-4568-87fc-ebf1e03a07ab@protonmail.com> (Skyler Ferris's message of "Fri, 16 Feb 2024 03:01:46 +0000")
Hi,
thanks for the review :)
Skyler Ferris <skyvine@protonmail.com> writes:
> Hi Tomas,
>
> Thanks for submitting this patch! I am adding some review notes to this
> issue in hopes of making the process more efficient for the committer. I
> noticed that `guix style` applies some minor changes to the definition
> of passt which should ideally be followed, but I don't expect that this
> would hold up the commit (and I'm not sure if it would be appropriate or
> intrusive to add a new patch to this thread with the style changes
> applied). Everything else looks good! I will add a couple more messages
> to this thread which contain full notes of items I reviewed, for
> transparency and clarity. Please let me know if there is anything I
> could do to improve my review process!
Only thing I would maybe mention is that as far as I can tell, I did not
receive any emails regarding your comments. I am not sure if that is
just how debbugs works, but if I did not open the bug for unrelated
reasons, I would have never noticed you commented.
Have a nice day,
Tomas Volf
next prev parent reply other threads:[~2024-02-16 21:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 19:17 [bug#69131] [PATCH 1/2] gnu: Add passt Tomas Volf
2024-02-14 19:19 ` [bug#69131] [PATCH 2/2] gnu: podman: Update to 4.9.3 Tomas Volf
2024-02-16 3:01 ` Skyler Ferris via Guix-patches via
2024-02-16 21:16 ` Tomas Volf [this message]
2024-02-16 3:03 ` Skyler Ferris via Guix-patches via
2024-02-16 3:02 ` [bug#69131] [PATCH 1/2] gnu: Add passt Skyler Ferris via Guix-patches via
2024-02-16 21:19 ` Tomas Volf
2024-02-16 21:14 ` [bug#69131] [PATCH v2 " Tomas Volf
2024-02-16 21:14 ` [bug#69131] [PATCH v2 2/2] gnu: podman: Update to 4.9.3 Tomas Volf
2024-03-02 16:25 ` bug#69131: [PATCH v2 1/2] gnu: Add passt Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734tsyurk.fsf@wolfsden.cz \
--to=~@wolfsden.cz \
--cc=69131@debbugs.gnu.org \
--cc=skyvine@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.