From: Marius Bakke <mbakke@fastmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: librsvg & Rust
Date: Sat, 23 Mar 2019 23:44:11 +0100 [thread overview]
Message-ID: <871s2x1a9w.fsf@fastmail.com> (raw)
In-Reply-To: <87h8btwn0t.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1836 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hi!
>
> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>
> [...]
>
>>>> I wanted to ask about this: is Rust supported on all the platforms we
>>>> support at the moment?
>>>
>>> According to Efraim and Danny, we have a problem at the moment.
>>> Presumably that can be worked around?
>>
>> Right, Rust currently only works on x86_64. In order to get this branch
>> started, let us either:
>>
>> * Revert back to 2.40.20, or
>> * Conditionally use the new version on supported platforms
>>
>> For the latter, I imagine something along the lines of...
>>
>> (define-public librsvg
>> (if (string-prefix? "x86_64" (or (%current-target-system)
>> (%current-system)))
>> librsvg-2.44
>> librsvg-2.40))
>
> It would have to be a macro so that the conditional is evaluated in a
> context where (%current-system) and (%current-target-system) have the
> right value, like the ‘glibc’ macro we had until commit
> 2d546858b139e5fcf2cbdf9958a17fd98803ac4c.
Right, thanks!
>> Preferences?
>
> I have a slight preference for having the same librsvg on all platforms.
>
> So we could add 2.44 alongside 2.40, but keep using 2.40 until our Rust
> package works on all the platforms.
>
> That said, if the chances are that Rust won’t work on all 4 platforms in
> the foreseeable future, the other option (upgrading on platforms where
> Rust is supported) may be preferable.
>
> Your call! :-)
I don't have a strong opinion, so I restored the previous librsvg
variant for now and kept the Rust one as 'librsvg-next' with commit
f67417a1b4d3fbd3a2e1593d32422e0d901ba367.
Let's "freeze" and try to merge this branch soon. Are there any pending
patches?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-03-23 22:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190220161027.17460.87383@vcs0.savannah.gnu.org>
[not found] ` <20190220161038.3F54B2040C@vcs0.savannah.gnu.org>
2019-03-06 11:05 ` librsvg & Rust Ludovic Courtès
2019-03-06 15:46 ` Marius Bakke
2019-03-06 16:24 ` ng0
2019-03-06 23:55 ` Mark H Weaver
2019-03-07 20:12 ` Efraim Flashner
2019-03-08 1:52 ` Danny Milosavljevic
2019-03-08 2:17 ` Danny Milosavljevic
2019-03-15 11:27 ` Ludovic Courtès
2019-03-15 11:29 ` Ludovic Courtès
2019-03-15 13:39 ` Marius Bakke
2019-03-15 15:14 ` Ivan Petkov
2019-03-23 16:53 ` Ludovic Courtès
2019-03-23 22:44 ` Marius Bakke [this message]
2019-04-03 21:30 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s2x1a9w.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.