From: Pierre Langlois <pierre.langlois@gmx.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: sl@eauchat.org, 54595@debbugs.gnu.org
Subject: [bug#54595] [PATCH 2/2] gnu: libfido2: Fix cross-compilation.
Date: Sun, 27 Mar 2022 15:04:09 +0100 [thread overview]
Message-ID: <871qyn7afq.fsf@gmx.com> (raw)
In-Reply-To: <cee568010458ba7d69c942bfb5c356f8956d6975.camel@telenet.be>
[-- Attachment #1: Type: text/plain, Size: 1848 bytes --]
Hi,
Maxime Devos <maximedevos@telenet.be> writes:
> [[PGP Signed Part:Undecided]]
> Sébastien Lerique schreef op zo 27-03-2022 om 21:29 [+0900]:
>> + ,(%current-target-system)
>> + "-pkg-config"))))
>
> This can be simplified with 'pkg-config-for-target':
>
> #:configure-flags
> (list (string-append "-DPKG_CONFIG_EXECUTABLE="
> (search-input-file %build-inputs
> (string-append "/bin/" ,(pkg-config-for-target)))))
For my own benefit trying to get better at writing gexps, I was
wondering how to write in order to remove the %build-inputs reference.
I came up with the following:
--8<---------------cut here---------------start------------->8---
(arguments
(list
#:configure-flags
#~(list #$@(if (%current-target-system)
(list
#~(string-append
"-DPKG_CONFIG_EXECUTABLE="
#+pkg-config "/bin/"
#$(pkg-config-for-target)))
'()))
#:phases
#~(modify-phases %standard-phases
;; regress tests enabled only for debug builds
(delete 'check))))
--8<---------------cut here---------------end--------------->8---
Would this a the better way to do this? It looks a bit complex to me so
I wonder if there's a simpler way. I'm also not entirely sure if it's
#+pkg-config or #$pkg-config, both seem to work, however I thought we
should be using #+ for native inputs and #$ for regular inputs.
Thanks,
Pierre
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]
next prev parent reply other threads:[~2022-03-27 14:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 12:28 [bug#54595] [PATCH 0/2] Fix cross-compilation for libfido2 Sébastien Lerique
2022-03-27 12:29 ` [bug#54595] [PATCH 1/2] gnu: libfido2: Use new style Sébastien Lerique
2022-03-27 12:29 ` [bug#54595] [PATCH 2/2] gnu: libfido2: Fix cross-compilation Sébastien Lerique
2022-03-27 12:36 ` Maxime Devos
2022-03-27 13:01 ` Sébastien Lerique
2022-03-27 14:04 ` Pierre Langlois [this message]
2022-03-27 15:43 ` Maxime Devos
2022-03-27 17:27 ` Pierre Langlois
2022-03-27 18:00 ` Maxime Devos
2022-03-27 22:12 ` Thiago Jung Bauermann via Guix-patches via
2022-03-27 15:44 ` Maxime Devos
2022-03-27 13:00 ` [bug#54595] [PATCH v2 1/2] gnu: libfido2: Use new style Sébastien Lerique
2022-03-27 13:00 ` [bug#54595] [PATCH v2 2/2] gnu: libfido2: Fix cross-compilation Sébastien Lerique
2022-03-27 14:09 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qyn7afq.fsf@gmx.com \
--to=pierre.langlois@gmx.com \
--cc=54595@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
--cc=sl@eauchat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.