all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Marius Bakke <marius@gnu.org>
To: Jim Newsome <jim@jimnewsome.net>,
	54439-done@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Cc: paul@unnservice.com, kiasoc5@tutanota.com,
	Efraim Flashner <efraim@flashner.co.il>,
	Felipe Balbi <felipe@balbi.sh>,
	Pierre Langlois <pierre.langlois@gmx.com>,
	56684-done@debbugs.gnu.orgPaulAlesius
Subject: bug#54439: [PATCH core-updates] gnu: rust: Use rust-1.60.0
Date: Thu, 04 Aug 2022 13:03:57 +0200	[thread overview]
Message-ID: <871qtwqnhe.fsf@gnu.org> (raw)
In-Reply-To: <20220804014716.785308-1-jim@jimnewsome.net>

[-- Attachment #1: Type: text/plain, Size: 2484 bytes --]

Jim Newsome <jim@jimnewsome.net> skriver:

> Hi, I'm new to this project and this code-review workflow, so please bear with me :).

Welcome!  You are doing great.  :-)

> It looks like there have been a few attempts here at updating Rust, including [Paul's], [Felipe's], and [my own].
>
> [Paul's]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54439#5
> [Felipe's]: https://issues.guix.gnu.org/54475#0
> [my own]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56684

Indeed.  :-/

> There's some discussion in this thread about using an updated mrustc and using that to cut out some earlier steps of the bootstrap chain. I propose leaving that out for the moment. It seems both nontrivial and orthogonal, so IMO would make more sense as its own thread / patch-set, which could be reviewed and merged independently, before or after this one.

This has recently been done on the 'staging' branch courtesy of Efraim.

> I think there's some confusion about where and how tests are enabled/disabled. IIUC in the current baseline, they are disabled in `rust-1.55`, which is the first version built with an earlier "official" rust:
>
> ```
>        ;; Only the final Rust is tested, not the intermediate bootstrap ones,
>        ;; for performance and simplicity.
>        #:tests? #f
> ```
>
> and subsequent versions inherit that via the `rust-bootstrapped-package` function.
>
> The latest and public version (currently `rust-1.57`) re-enables most of the tests and fixes up some things so that the tests pass.
>
> So I think the approach here when adding versions is to change the current latest (1.57) to the simpler form that keeps tests disabled, add any additional necessary steps, and have the test-reenabling code again in the latest version.

That is my understanding too.

> 2 patches included:
>
> * First is a pure refactor to decouple  "rust-1.57" from "rust" to help avoid confusion in the future.
> * Second adds 1.58, 1.59, and 1.60, and makes rust-1.60 the new rust.
>
> In the latter patch I also tried building each version with a Rust 2 versions back instead of just 1 version back, to see if any can be left out. Unfortunately they couldn't. I'm including some of the errors in the comments for reference.

LGTM, I've pushed both patches to the 'staging' branch since Rust was
already patched there and it has not started evaluating yet.

Note: I also added a copyright line for you, hope that was okay.

Closing the issue, but feel free to continue the discussion.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

  reply	other threads:[~2022-08-04 11:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18  0:21 [bug#54439] Rust: Add Rust 1.59, set default to 1.59 Paul Alesius
2022-03-18  8:23 ` Maxime Devos
2022-03-18  8:55   ` Paul Alesius
2022-03-18  8:25 ` Maxime Devos
2022-03-18  8:25 ` Maxime Devos
2022-03-18  8:26 ` Maxime Devos
2022-03-20 13:58 ` Maxime Devos
2022-03-20 15:36   ` Paul Alesius
2022-03-21  3:31 ` [bug#54439] kiasoc5--- via Guix-patches via
2022-03-26 13:36   ` [bug#54439] Pierre Langlois
2022-04-11 20:04 ` [bug#54439] kiasoc5--- via Guix-patches via
2022-05-20  2:39 ` [bug#54439] Rust 1.61.0 kiasoc5--- via Guix-patches via
2022-06-30 18:57   ` kiasoc5 via Guix-patches via
2022-06-30 20:17     ` Tobias Geerinckx-Rice via Guix-patches via
2022-07-01  1:11       ` kiasoc5 via Guix-patches via
2022-07-01  9:39         ` ( via Guix-patches via
2022-07-03  4:25           ` kiasoc5 via Guix-patches via
2022-08-04  1:47 ` [bug#54439] [PATCH core-updates] gnu: rust: Use rust-1.60.0 Jim Newsome
2022-08-04 11:03   ` Marius Bakke [this message]
2022-08-04 15:08     ` Jim Newsome
2022-08-04  1:47 ` [bug#54439] [PATCH core-updates 1/2] gnu: rust: decouple rust-1.57 and "rust" Jim Newsome
2022-08-04  1:47   ` [bug#54439] [PATCH core-updates 2/2] gnu: rust: Use rust-1.60.0 Jim Newsome

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qtwqnhe.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=54439-done@debbugs.gnu.org \
    --cc=56684-done@debbugs.gnu.orgPaulAlesius \
    --cc=efraim@flashner.co.il \
    --cc=felipe@balbi.sh \
    --cc=jim@jimnewsome.net \
    --cc=kiasoc5@tutanota.com \
    --cc=maximedevos@telenet.be \
    --cc=paul@unnservice.com \
    --cc=pierre.langlois@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.