all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: 58444@debbugs.gnu.org
Cc: "Mathieu Othacehe" <othacehe@gnu.org>,
	"Ludovic Courtès" <ludo@gnu.org>,
	"Denis 'GNUtoo' Carikli" <GNUtoo@cyberdimension.org>
Subject: bug#58444: Make gtk use librsvg on aarch64 again.
Date: Tue, 11 Oct 2022 17:56:47 +0200	[thread overview]
Message-ID: <871qrebbgg.fsf@pelzflorian.de> (raw)
In-Reply-To: <87leqf382h.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 19 Sep 2022 13:41:26 +0200")

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

Hi Guix,

Mathieu Othacehe <othacehe@gnu.org> writes at <https://issues.guix.gnu.org/57933>:
> That's because `gst-plugins-bad` and `librsvg-bootstrap` both refer to
> `librsvg` which depends on Rust which is only supported on x86_64-linux.

This isn’t entirely true.  Since
32a87714f4507f853824d82d9c6ca10e1405c8eb, bordeaux has substitutes for
librsvg for aarch64.

I wrote a patch but probably it would rebuild the world.  I haven’t
tried compiling yet.  Would using (or (target-aarch64?)
                                      (target-x86-64?)) be better?


[-- Attachment #2: gnu-gtk-Use-recent-librsvg-on-aarch64-again.patch --]
[-- Type: text/x-patch, Size: 1679 bytes --]

From: Florian Pelz <pelzflorian@pelzflorian.de>
Date: Tue, 11 Oct 2022 16:57:06 +0200
Subject: [PATCH] gnu: gtk: Use recent librsvg on aarch64 again.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Commit 75e24eec1ed9772dbcb6737270076eca571dc4ea assumed librsvg didn’t
support aarch64, but it *is* supported since commit
32a87714f4507f853824d82d9c6ca10e1405c8eb.

* gnu/packages/gtk.scm (gtk)[propagated-inputs]: Check if librsvg is supported.
---
 gnu/packages/gtk.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index faf4d6f7eb..985031c7b2 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -32,6 +32,7 @@
 ;;; Copyright © 2022 Zhu Zihao <all_but_last@163.com>
 ;;; Copyright © 2022 Benjamin Slade <slade@lambda-y.net>
 ;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
+;;; Copyright © 2022 Florian Pelz <pelzflorian@pelzflorian.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -969,9 +970,11 @@ (define-public gtk+-2
     (outputs '("out" "bin" "doc" "debug"))
     (propagated-inputs
      (list atk cairo
-           (if (target-x86-64?)
-             librsvg-bootstrap
-             librsvg-2.40)
+           (let ((target (or (%current-target-system)
+                             (%current-system))))
+             (if (supported-package? librsvg-bootstrap target)
+                 librsvg-bootstrap
+                 librsvg-2.40))
            glib pango))
     (inputs
      (list cups

base-commit: 59911ae29442aba18bcb53233e793d8f3d264504
-- 
2.37.3


[-- Attachment #3: Type: text/plain, Size: 18 bytes --]


Regards,
Florian

  parent reply	other threads:[~2022-10-11 16:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19 11:41 bug#57933: Gtk is unsupported on i686-linux Mathieu Othacehe
2022-10-09 20:36 ` Ludovic Courtès
2022-10-10 15:40   ` Ludovic Courtès
2022-10-11 15:56 ` pelzflorian (Florian Pelz) [this message]
2022-10-11 17:45   ` bug#58444: Make gtk use librsvg on aarch64 again pelzflorian (Florian Pelz)
2022-10-12 19:38     ` pelzflorian (Florian Pelz)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qrebbgg.fsf@pelzflorian.de \
    --to=pelzflorian@pelzflorian.de \
    --cc=58444@debbugs.gnu.org \
    --cc=GNUtoo@cyberdimension.org \
    --cc=ludo@gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.