all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 50490@debbugs.gnu.org
Subject: [bug#50490] [PATCH 0/5] Some julia packages
Date: Mon, 27 Sep 2021 19:03:06 +0200	[thread overview]
Message-ID: <86zgryymr9.fsf_-_@gmail.com> (raw)
In-Reply-To: <eca237a402eef4f1c053a937ea24138e366e33d3.1631624546.git.efraim@flashner.co.il> (Efraim Flashner's message of "Tue, 14 Sep 2021 21:19:25 +0300")

Hi Efraim,

On mar., 14 sept. 2021 at 21:19, Efraim Flashner <efraim@flashner.co.il> wrote:
> * gnu/packages/julia-xyz.scm (julia-sass): New variable.
> ---
>  gnu/packages/julia-xyz.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/julia-xyz.scm b/gnu/packages/julia-xyz.scm
> index a80964c2b0..2f953a33b7 100644
> --- a/gnu/packages/julia-xyz.scm
> +++ b/gnu/packages/julia-xyz.scm
> @@ -3403,6 +3403,28 @@ (define-public julia-safetestsets
>  a loadable module.")
>        (license license:expat))))
>
> +(define-public julia-sass
> +  (package
> +    (name "julia-sass")
> +    (version "0.2.0")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +               (url "https://github.com/piever/Sass.jl")
> +               (commit (string-append "v" version))))
> +        (file-name (git-file-name name version))
> +        (sha256
> +         (base32 "0y7kkkj717h5cj659ssry89i5r64symr6pvhr6vv4qmaxrnjxj92"))))
> +    (build-system julia-build-system)
> +    (propagated-inputs
> +     `(("julia-libsass-jll" ,julia-libsass-jll)))
> +    (home-page "https://github.com/piever/Sass.jl")
> +    (synopsis "Compile scss and sass file to css in Julia")

Again, I would remove «in Julia>..

> +    (description "This library provides a simple Julian API to use
> the

I would write «This package provides…»

> +@code{libsass} library to compile scss and sass files to css.")
> +    (license license:expat)))

LGTM.

Cheers,
simon




  reply	other threads:[~2021-09-27 17:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14 13:08 [bug#50582] [PATCH 0/4] Julia-documenter Efraim Flashner
2021-09-14 13:11 ` [bug#50582] [PATCH 1/4] gnu: Add julia-libsass-jll Efraim Flashner
2021-09-27 17:01   ` [bug#50490] [PATCH 0/5] Some julia packages zimoun
2021-09-14 13:12 ` [bug#50582] [PATCH 2/4] gnu: Add julia-sass Efraim Flashner
2021-09-27 17:03   ` zimoun [this message]
2021-09-14 18:19 ` [bug#50490] [PATCH 3/4] gnu: Add julia-ansicoloredprinters Efraim Flashner
2021-09-27 17:04   ` [bug#50490] [PATCH 0/5] Some julia packages zimoun
2021-09-14 18:19 ` [bug#50490] [PATCH 4/4] gnu: Add julia-documenter Efraim Flashner
2021-09-27 17:11   ` [bug#50490] [PATCH 0/5] Some julia packages zimoun
2021-09-30 11:18     ` Efraim Flashner
     [not found] ` <handler.50582.B.163162505210361.ack@debbugs.gnu.org>
2021-09-14 18:31   ` [bug#50582] Acknowledgement ([PATCH 0/4] Julia-documenter) Efraim Flashner
2021-09-27 17:15     ` [bug#50582] [PATCH 0/4] Julia-documenter zimoun
2021-09-29  7:21       ` Efraim Flashner
2021-09-30 11:26       ` bug#50582: " Efraim Flashner
  -- strict thread matches above, loose matches on Subject: below --
2021-09-09 18:16 [bug#50490] [PATCH 0/5] Some julia packages Efraim Flashner
2021-09-14 17:38 ` zimoun
2021-09-22 12:13 ` [bug#50490] [PATCH 1/5] gnu: Add julia-quadgk Efraim Flashner
2021-09-27 16:51   ` [bug#50490] [PATCH 0/5] Some julia packages zimoun
2021-09-22 12:13 ` [bug#50490] [PATCH 2/5] gnu: Add julia-measurements Efraim Flashner
2021-09-27 16:53   ` [bug#50490] [PATCH 0/5] Some julia packages zimoun
2021-09-22 12:13 ` [bug#50490] [PATCH 3/5] gnu: Add julia-mlstyle Efraim Flashner
2021-09-27 16:54   ` [bug#50490] [PATCH 0/5] Some julia packages zimoun
2021-09-22 12:13 ` [bug#50490] [PATCH 4/5] gnu: Add julia-pycall Efraim Flashner
2021-09-27 16:58   ` [bug#50490] [PATCH 0/5] Some julia packages zimoun
2021-09-22 12:13 ` [bug#50490] [PATCH 5/5] gnu: Add julia-ansicoloredprinters Efraim Flashner
2021-09-27 16:59   ` [bug#50490] [PATCH 0/5] Some julia packages zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zgryymr9.fsf_-_@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=50490@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.