all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: Andy Tai <atai@atai.org>, 59059@debbugs.gnu.org
Subject: [bug#59059] [PATCH] gnu: terminator: Renamed to "gnome-terminator" and update to 2.1.2
Date: Wed, 11 Jan 2023 23:09:31 +0100	[thread overview]
Message-ID: <86zgao206c.fsf@gmail.com> (raw)
In-Reply-To: <CAJsg1E_OjaReYXyX_VvgCjQaJoi8w0-2AszFQYGdSyHJi4ecXw@mail.gmail.com>

Hi,

This patch LGTM except two minor comments.

On Sat, 05 Nov 2022 at 12:45, Andy Tai <atai@atai.org> wrote:

> * gnu/packages/gnome.scm (gnome-terminator): Rename variable from
> (terminator(:  …this.  Redefine using DEPRECATED-PACKAGE.
           --^
       Here

> +(define-public terminator
> +    (deprecated-package "terminator" gnome-terminator))
> +

Incorrect indentation.  Well, I noticed that it was also the case for
other of your submissions.  Maybe, give a look at your editor settings –
if it is Emacs, the repository contains .dir-locals.el which implements
the convention.


Cheers,
simon




  parent reply	other threads:[~2023-01-11 22:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-05 19:45 [bug#59059] [PATCH] gnu: terminator: Renamed to "gnome-terminator" and update to 2.1.2 Andy Tai
2022-12-23  6:43 ` [bug#59059] ping Andy Tai
2023-01-11 22:09 ` zimoun [this message]
2023-01-13  6:51 ` [bug#59059] [PATCH] gnu: terminator: Renamed to "gnome-terminator" and update to 2.1.2 Andy Tai
2023-01-17 19:59 ` [bug#59059] ping Andy Tai
2023-01-28  9:25 ` [bug#59059] [PATCH v2] gnu: terminator: Renamed to "gnome-terminator" and update to 2.1.2 Andy Tai
2023-01-29  6:19   ` [bug#59059] [PATCH] " 宋文武 via Guix-patches via
2023-01-29  6:22     ` Andy Tai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zgao206c.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=59059@debbugs.gnu.org \
    --cc=atai@atai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.