From: Roman Scherer <roman.scherer@burningswell.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 61959@debbugs.gnu.org
Subject: [bug#61959] [PATCH 0/7] Add some Asahi Linux packages
Date: Sun, 05 Mar 2023 11:53:46 +0100 [thread overview]
Message-ID: <86zg8rlb6k.fsf@burningswell.com> (raw)
In-Reply-To: <87mt4sl88u.fsf@elephly.net>
[-- Attachment #1: Type: text/plain, Size: 2667 bytes --]
Hi Ricardo,
I updated the patch series and sent v2 of it.
Thanks for your review!
Roman
Ricardo Wurmus <rekado@elephly.net> writes:
> Thank you for the patches.
>
> Here a couple of comments:
>
> * Please do not use Github archive URLs like
> "https://github.com/AsahiLinux/m1n1/archive/v….tar.gz". These are
> automatically generated and have changed in the past, leading to
> different hashes. In the interest of reproducibility please use
> “git-fetch” with plain commit hashes instead.
>
> * Please use G-expressions instead of simple quoting with (assoc-ref
> outputs "out"). Instead of this:
>
> --8<---------------cut here---------------start------------->8---
> (arguments
> `(#:phases
> (modify-phases %standard-phases
> (replace 'configure
> (lambda _
> (setenv "RELEASE" "1")))
> (replace 'install
> (lambda* (#:key outputs #:allow-other-keys)
> (let ((dir (string-append (assoc-ref outputs "out") "/libexec/")))
> (mkdir-p dir)
> (copy-file "build/m1n1.bin" (string-append dir "m1n1.bin")))))
> ;; There are no tests
> (delete 'check))))
> --8<---------------cut here---------------end--------------->8---
>
>
> Please do this:
>
> --8<---------------cut here---------------start------------->8---
> (arguments
> (list
> ;; There are no tests
> #:tests? #false
> #:phases
> #~(modify-phases %standard-phases
> (replace 'configure
> (lambda _
> (setenv "RELEASE" "1")))
> (replace 'install
> (lambda _
> (let ((dir (string-append #$output "/libexec/")))
> (mkdir-p dir)
> (copy-file "build/m1n1.bin" (string-append dir "m1n1.bin"))))))))
> --8<---------------cut here---------------end--------------->8---
>
> This also applies to “asahi-fwextract”.
>
> * The string labels for inputs are a deprecated style. Please use plain
> lists of package variables. If you want to modify an inherited list
> of inputs such as in “asahi-mesa” please use “modify-inputs”.
>
> * In “asahi-fwextract” the build phase “'remove-vendor” should be a
> source snippet instead.
>
> * Please use pyproject-build-system instead of python-build-system. The
> pyproject-build-system is going to be the default in the future, and
> it would be good to use it already to address any incompatibilities
> early.
>
> Could you please send a new version of this patch set? Thanks again!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 528 bytes --]
next prev parent reply other threads:[~2023-03-05 10:56 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 14:44 [bug#61959] [PATCH 0/7] Add some Asahi Linux packages Roman Scherer
2023-03-04 14:46 ` [bug#61959] [PATCH 1/7] gnu: Add m1n1 Roman Scherer
2023-03-04 14:46 ` [bug#61959] [PATCH 2/7] gnu: Add u-boot-apple-m1 Roman Scherer
2023-03-04 14:46 ` [bug#61959] [PATCH 3/7] gnu: Add asahi-fwextract Roman Scherer
2023-03-04 14:46 ` [bug#61959] [PATCH 4/7] gnu: libdrm: Update to 2.4.114 Roman Scherer
2023-03-04 14:46 ` [bug#61959] [PATCH 5/7] gnu: Add asahi-mesa Roman Scherer
2023-03-04 14:46 ` [bug#61959] [PATCH 6/7] gnu: Add asahi-mesa-headers Roman Scherer
2023-03-04 14:46 ` [bug#61959] [PATCH 7/7] gnu: Add asahi-mesa-utils Roman Scherer
2023-03-04 17:38 ` [bug#61959] [PATCH 0/7] Add some Asahi Linux packages Ricardo Wurmus
2023-03-05 10:53 ` Roman Scherer [this message]
2023-03-05 11:15 ` Roman Scherer
2023-03-04 19:42 ` Winter via Guix-patches via
2023-03-05 10:53 ` [bug#61959] [PATCH v2 1/7] gnu: Add m1n1 Roman Scherer
2023-03-05 10:53 ` [bug#61959] [PATCH v2 2/7] gnu: Add u-boot-apple-m1 Roman Scherer
2023-03-05 10:53 ` [bug#61959] [PATCH v2 3/7] gnu: libdrm: Update to 2.4.114 Roman Scherer
2023-03-05 10:53 ` [bug#61959] [PATCH v2 4/7] gnu: Add asahi-fwextract Roman Scherer
2023-03-05 10:53 ` [bug#61959] [PATCH v2 5/7] gnu: Add asahi-mesa Roman Scherer
2023-03-05 10:53 ` [bug#61959] [PATCH v2 6/7] gnu: Add asahi-mesa-headers Roman Scherer
2023-03-05 10:53 ` [bug#61959] [PATCH v2 7/7] gnu: Add asahi-mesa-utils Roman Scherer
2023-03-05 16:13 ` [bug#61959] [PATCH v3 0/7] Add some Asahi Linux packages Roman Scherer
2023-03-05 16:13 ` [bug#61959] [PATCH v3 1/7] gnu: Add m1n1 Roman Scherer
2023-03-05 16:13 ` [bug#61959] [PATCH v3 2/7] gnu: Add u-boot-apple-m1 Roman Scherer
2023-03-05 16:13 ` [bug#61959] [PATCH v3 3/7] gnu: libdrm: Update to 2.4.114 and adjust renamed options Roman Scherer
2023-03-05 16:14 ` [bug#61959] [PATCH v3 4/7] gnu: Add asahi-fwextract Roman Scherer
2023-03-05 16:14 ` [bug#61959] [PATCH v3 5/7] gnu: Add asahi-mesa Roman Scherer
2023-03-05 16:14 ` [bug#61959] [PATCH v3 6/7] gnu: Add asahi-mesa-headers Roman Scherer
2023-03-05 16:14 ` [bug#61959] [PATCH v3 7/7] gnu: Add asahi-mesa-utils Roman Scherer
2023-03-05 23:43 ` [bug#61959] [PATCH 0/7] Add some Asahi Linux packages Denis 'GNUtoo' Carikli
2023-03-07 4:14 ` Winter via Guix-patches via
2023-03-08 12:14 ` Roman Scherer
2023-03-08 12:13 ` [bug#61959] [PATCH v4 0/7] Change patch order Roman Scherer
2023-03-08 12:13 ` [bug#61959] [PATCH v4 1/7] gnu: Add m1n1 Roman Scherer
2023-03-08 12:13 ` [bug#61959] [PATCH v4 2/7] gnu: Add u-boot-apple-m1 Roman Scherer
2023-03-08 12:13 ` [bug#61959] [PATCH v4 3/7] gnu: libdrm: Update to 2.4.114 and adjust renamed options Roman Scherer
2023-03-08 12:13 ` [bug#61959] [PATCH v4 4/7] gnu: Add asahi-mesa Roman Scherer
2023-03-08 12:13 ` [bug#61959] [PATCH v4 5/7] gnu: Add asahi-mesa-headers Roman Scherer
2023-03-08 12:13 ` [bug#61959] [PATCH v4 6/7] gnu: Add asahi-mesa-utils Roman Scherer
2023-03-08 12:13 ` [bug#61959] [PATCH v4 7/7] gnu: Add asahi-fwextract Roman Scherer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zg8rlb6k.fsf@burningswell.com \
--to=roman.scherer@burningswell.com \
--cc=61959@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.