all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: "Clément Lassieur" <clement@lassieur.org>
Cc: 26830@debbugs.gnu.org
Subject: bug#26830: Allow services to implement a 'reload' action
Date: Tue, 09 May 2017 17:37:25 +0200	[thread overview]
Message-ID: <86vapa6nyi.fsf@gmail.com> (raw)
In-Reply-To: <87d1bjtlpd.fsf@lassieur.org>


Hi Clément,

> Services do not have to implement 'reload' and if, say, foo-daemon
> doesn't implement it, 'herd reload foo-daemon' will return 1 and display
> a message saying that foo-deamon does not have an action 'reload'.
> That's the reason of the #f default value.
>
> WDYT?

Your whole serie LGTM for me !

I have just one small concern, there is a already a "reload" action on
shepherd root service.

For instance you can call "herd reload root conf.scm".

Maybe it will be unclear for users how reload action differs on root
service where it takes an argument and guix services where it does not.

You could maybe mention that in the documentation and/or in the code ?

Thanks,

Mathieu

  parent reply	other threads:[~2017-05-09 15:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-08 15:25 bug#26830: Allow services to implement a 'reload' action Clément Lassieur
2017-05-08 15:28 ` bug#26830: [PATCH 1/4] services: shepherd: " Clément Lassieur
2017-05-08 15:28   ` bug#26830: [PATCH 2/4] gnu: services: nginx: Add " Clément Lassieur
2017-05-08 15:28   ` bug#26830: [PATCH 3/4] gnu: services: prosody: " Clément Lassieur
2017-05-08 15:28   ` bug#26830: [PATCH 4/4] gnu: services: dovecot: " Clément Lassieur
2017-05-09 15:37 ` Mathieu Othacehe [this message]
2017-05-10 19:31   ` bug#26830: [PATCH] services: shepherd: Allow services to implement " Clément Lassieur
2017-05-11  7:13     ` Clément Lassieur
2017-05-11 12:40       ` Clément Lassieur
2017-05-11 12:57         ` Mathieu Othacehe
2017-05-10 19:31   ` bug#26830: " Clément Lassieur
2017-05-11 21:24   ` Ludovic Courtès
2017-05-11 23:08     ` Clément Lassieur
2017-05-12  8:25       ` Ludovic Courtès
2017-05-12  8:57         ` Clément Lassieur
2018-01-28 20:34           ` [bug#26830] " Danny Milosavljevic
2018-01-28 23:23             ` Clément Lassieur
2018-07-11 22:00     ` Ludovic Courtès
2018-07-12 13:06       ` Clément Lassieur
2022-03-23 12:56       ` zimoun
2022-03-24  8:41         ` Ludovic Courtès
2022-03-24 13:52           ` Oleg Pykhalov
2022-03-26 20:46             ` Ludovic Courtès
2022-03-26 21:14               ` Maxime Devos
2022-03-29 13:36                 ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86vapa6nyi.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=26830@debbugs.gnu.org \
    --cc=clement@lassieur.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.