[bug#64209] [PATCH 00/14] Add ocaml-lsp-server and its dependencies

[pukkamustard <pukkamustard@posteo.net>]

Hi,

Thanks for the patches!

Couldn't look at everything yet, just some initial remarks.

Benjamin <benjamin@uvy.fr> writes:

> Hello,
>
> These patches add ocaml-lsp-server package.
>
> ...
>
> Benjamin (14):
>   gnu: Fix ocaml-dune-build-info

Lgtm, this patch would fix #63947.

>   gnu: Add ocaml-dune-rpc.

There seems to be an issue with the ordering of the patches. I can not
build ocaml-dune-rpc, as it requires ocaml-ordering which is only
available a couple of commits later.

In general, try to make things build at every commit. In this case it
requires re-ordering the commits.

Could you explain why the 'remove-vendor phase is needed? It seems like
if code is vendored it should maybe also be removed in the `dune`
package?

As Ludo mentioned, the description and synopses could use a little bit
of improvement. For example descriptions should be full sentences.

>   gnu: Add ocaml-chrome-trace.

We need a more descriptive description.

I guess the descriptions come from OPAM. Unfortunately Guix has stricter
requirements than OPAM...:)

-pukkamustard