From: Sarah Morgensen <iskarian@mgsn.dev>
To: 49916@debbugs.gnu.org
Cc: Ricardo Wurmus <rekado@elephly.net>
Subject: bug#49916: etc/committer: backtrace on gexp
Date: Fri, 06 Aug 2021 12:18:11 -0700 [thread overview]
Message-ID: <86o8aa1ix8.fsf@mgsn.dev> (raw)
Hello Guix,
(Ricardo, I've Cc'd you since it seems etc/committer.scm is mostly your
work.)
It looks like etc/committer.scm is choking on gexps on core-updates-frozen:
--8<---------------cut here---------------start------------->8---
~/guix-cu-frozen [env]$ etc/committer.scm
ice-9/read.scm:126:4: In procedure read-expr*:
gnu/packages/games.scm:13005:11: Unknown # object: "#~"
--8<---------------cut here---------------end--------------->8---
...and this is the offending package:
--8<---------------cut here---------------start------------->8---
(define-public 0ad-data
(package
(name "0ad-data")
(version "0.0.23b-alpha")
(source
(origin
(method url-fetch)
(uri (string-append "https://releases.wildfiregames.com/0ad-"
version "-unix-data.tar.xz"))
(file-name (string-append name "-" version ".tar.xz"))
(sha256
(base32
"04x7729hk6zw1xj3n4s4lvaviijsnbjf5rhzvjxlr5fygvg4l6z1"))
(modules '((guix build utils)))
(snippet
#~(begin
(for-each (lambda (name)
(let* ((dir (string-append "binaries/data/mods/" name))
(file (string-append dir "/" name ".zip"))
(unzip #$(file-append unzip "/bin/unzip")))
(invoke unzip "-d" dir file)
(delete-file file)))
'("mod" "public"))
#t))))
(build-system trivial-build-system)
--8<---------------cut here---------------end--------------->8---
I think with the changes from new style inputs, gexps in packages are
going to become more common, so etc/committer.scm should support them.
WDYT?
--
Sarah
next reply other threads:[~2021-08-06 19:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 19:18 Sarah Morgensen [this message]
2021-08-07 10:25 ` bug#49916: etc/committer: backtrace on gexp Maxime Devos
2021-08-07 12:06 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o8aa1ix8.fsf@mgsn.dev \
--to=iskarian@mgsn.dev \
--cc=49916@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.