From: zimoun <zimon.toutoune@gmail.com>
To: 57031@debbugs.gnu.org
Cc: "\(" <paren@disroot.org>
Subject: [bug#57031] [PATCH v2 2/2] scripts: Warn the first time pull or package is run as root.
Date: Wed, 26 Oct 2022 20:14:49 +0200 [thread overview]
Message-ID: <86lep2jvty.fsf@gmail.com> (raw)
In-Reply-To: <20220911195941.8442-2-paren@disroot.org>
Hi,
On Sun, 11 Sep 2022 at 20:59, "\( via Guix-patches" via <guix-patches@gnu.org> wrote:
> * guix/scripts/pull.scm (guix-pull): Warn the first time it's being
> run as root.
> * guix/scripts/package.scm (guix-package*): Likewise if the new
> `root-hint?' argument is `#t'.
> (guix-package): Use `#:root-hint? #t' in invocation of `guix-package*'.
> * guix/scripts/install.scm (guix-install): Likewise.
> * guix/scripts/remove.scm (guix-remove): Likewise.
> * guix/scripts/remove.scm (guix-upgrade): Likewise.
>
> A pretty common beginner mistake, it seems, is assuming that since
> every other package manager you've used requires root for installing,
> removing, and upgrading packages, Guix must too.
>
> This commit tries to make it harder to make such an assumption, by
> making commands such as `pull`, `package`, and `upgrade` display
> a warning the first time they are run as root.
This patch LGTM aside…
> - (guix-package* opts))
> + (guix-package* opts #:root-hint? #t))
[...]
> - (guix-package* opts))
> + (guix-package* opts #:root-hint? #t))
[...]
> -(define (guix-package* opts)
> +(define* (guix-package* opts #:key (root-hint? #f))
Why this ’root-hint?’ argument? Is it useful or can we drop it?
> + (when (and root-hint?
> + (not (hint-given? 'package-root-hint))
> + (zero? (getuid)))
> + (record-hint 'package-root-hint)
> + (warning (G_ "this command is user-specific, so running it as root \
> +will affect only the 'root' user~%")))
[...]
> + (when (and (not (hint-given? 'pull-root-hint))
> + (zero? (getuid)))
> + (record-hint 'pull-root-hint)
> + (warning (G_ "this command is user-specific, so running it as root \
> +will affect only the 'root' user~%")))
It looks pretty similar. Is it possible to avoid the duplication?
Cheers,
simon
next prev parent reply other threads:[~2022-10-26 22:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-07 11:14 [bug#57031] [PATCH] scripts: Show a hint the first time some commands are run as root ( via Guix-patches via
2022-08-07 11:19 ` [bug#57031] [PATCH v2] " ( via Guix-patches via
2022-08-07 11:22 ` ( via Guix-patches via
2022-09-05 21:11 ` [bug#57031] [PATCH] " Ludovic Courtès
2022-09-11 13:05 ` ( via Guix-patches via
2022-09-11 19:59 ` [bug#57031] [PATCH v2 1/2] ui: Make one-time hint API public ( via Guix-patches via
2022-09-11 19:59 ` [bug#57031] [PATCH v2 2/2] scripts: Warn the first time pull or package is run as root ( via Guix-patches via
2022-10-26 18:14 ` zimoun [this message]
2022-10-27 5:52 ` ( via Guix-patches via
2022-10-27 8:23 ` zimoun
2022-10-28 14:33 ` ( via Guix-patches via
2022-10-27 19:42 ` [bug#57031] [PATCH v3 1/2] ui: Make one-time hint API public ( via Guix-patches via
2022-10-27 19:42 ` [bug#57031] [PATCH v3 2/2] scripts: Warn the first time pull or package is run as root ( via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86lep2jvty.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=57031@debbugs.gnu.org \
--cc=paren@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.