all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bonface Munyoki K. <me@bonfacemunyoki.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 47593@debbugs.gnu.org, jgart@dismail.de
Subject: [bug#47593] [PATCH 3/6] gnu: python-xyz: Add python-uqbar.
Date: Tue, 13 Apr 2021 23:52:15 +0300	[thread overview]
Message-ID: <86fsztoqkg.fsf@bonfacemunyoki.com> (raw)
In-Reply-To: <YHWZNENNZY3ih7P7@3900XT> (Efraim Flashner's message of "Tue, 13 Apr 2021 16:14:28 +0300")

[-- Attachment #1: Type: text/plain, Size: 3219 bytes --]

Efraim Flashner <efraim@flashner.co.il> writes:

> I haven't tried building this package yet. The sphinx packages are in
> sphinx.scm and the graphviz packages are in graphviz.scm. I think I
> would put it in graphviz.
>

Now that you've pointed it out, I see it! That
makes sense.

[...]

> guix lint should've caught this.

I seem to have skipped doing this. I need to find
a way to integrating "guix lint" to my Emacs
workflow since I seem to always somehow forget to
do this.

> If the pypi version from 'guix import
> ppyi uqbar' doesn't work for building then you should use git-fetch to
> download the source. The github archive URLs tend to get regenerated
> from time to time.

I went with the GitHub version since the pypi version
doesn't have tests. So in such cases, is it still
preferable to use the pypi version?

>> +       (sha256
>> +        (base32
>> +         "02kfvwh94ca0y3hsfrc071ga3g3vqflhyv4w4hif34dyj2skvpa8"))))
>> +    (build-system python-build-system)
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'unpack 'patch
>> +           (lambda _
>> +             (substitute* "setup.py"
>> +               ;; Latest versions of sphink-rtd-theme require npm to build.
>> +               (("sphinx-rtd-theme >= 0.4.0") "sphinx-rtd-theme >= 0.2.4")
>> +               (("black == 19.10b0") "black >= 19.10b0"))
>> +             #t))
>> +         (replace 'check
>> +           (lambda _
>> +             (invoke "python" "-m" "pytest" "tests")
>
> We want the ability to skip the tests, so this should be
> (lambda* (#:key tests? #:allow-other-keys)
>   (when tests?
>     (invoke ...
>

Never knew this! Learnt something new. Thanks!

>> +             #t)))))
>> +    (propagated-inputs
>> +     `(("graphviz" ,graphviz)
>
> Is it possible to substitute the actual calls to the graphviz binaries
> in the package?

Not really. However...

> We don't want to have to propagate non-python packages.
>

... We could add the graphviz to native
inputs since it's only required at build-time when
running one of the tests.

>> +       ("python-black" ,python-black)
>> +       ("python-sphinx" ,python-sphinx)
>> +       ("python-sphinx-rtd-theme"
>> +        ,python-sphinx-rtd-theme)
>> +       ("python-unidecode" ,python-unidecode)))
>> +    (native-inputs
>> +     `(("python-flake8" ,python-flake8)
>> +       ("python-isort" ,python-isort)
>> +       ("python-mypy" ,python-mypy)
>> +       ("python-pytest" ,python-pytest)
>> +       ("python-pytest-cov" ,python-pytest-cov)))
>> +    (home-page
>> +     "https://github.com/josiah-wolf-oberholtzer/uqbar")
>> +    (synopsis
>> +     "Tools for building documentation with Sphinx, Graphviz and LaTeX")
>> +    (description
>> +     "Tools for building documentation with Sphinx, Graphviz and LaTeX")
>
> This should be a full sentence.
>

Noted :)
>> +    (license license:expat)))
>> -- 
>> 2.31.0
>> 
>> 
>> 
>> 

-- 
Bonface M. K. D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
Humble GNU Emacs User / Bearer of scheme-y parens
Curator: <https://upbookclub.com> / Twitter: @BonfaceKilz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 865 bytes --]

  reply	other threads:[~2021-04-13 20:53 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-04 12:16 [bug#47593] [PATCH 0/6] *** Add Python Abjad v3.3 *** BonfaceKilz
2021-04-04 12:19 ` BonfaceKilz
2021-04-04 12:20   ` [bug#47593] [PATCH 1/6] gnu: python-xyz: Add python-roman BonfaceKilz
2021-04-13 13:14     ` Efraim Flashner
2021-04-13 20:12       ` Bonface Munyoki K.
2021-04-04 12:20   ` [bug#47593] [PATCH 2/6] gnu: python-check: Add python-pytest-helpers-namespace BonfaceKilz
2021-04-04 12:20   ` [bug#47593] [PATCH 3/6] gnu: python-xyz: Add python-uqbar BonfaceKilz
2021-04-13 13:14     ` Efraim Flashner
2021-04-13 20:52       ` Bonface Munyoki K. [this message]
2021-04-14 15:14         ` Efraim Flashner
2021-04-04 12:20   ` [bug#47593] [PATCH 4/6] gnu: python-xyz: Add python-setuptools-declarative-requirements BonfaceKilz
2021-04-13 13:14     ` Efraim Flashner
2021-04-13 20:53       ` Bonface Munyoki K.
2021-04-04 12:20   ` [bug#47593] [PATCH 5/6] gnu: python-xyz: Add python-quicktions BonfaceKilz
2021-04-13 13:14     ` Efraim Flashner
2021-04-13 21:10       ` Bonface Munyoki K.
2021-04-14 15:17         ` Efraim Flashner
2021-04-04 12:20   ` [bug#47593] [PATCH 6/6] gnu: python-xyz: Add python-abjad BonfaceKilz
2021-04-13 13:14     ` Efraim Flashner
2021-04-13 21:00       ` Bonface Munyoki K.
2021-04-14 15:19         ` Efraim Flashner
2021-04-14 20:54 ` [bug#47593] [PATCH v2 0/6] " BonfaceKilz
2021-04-14 20:54   ` [bug#47593] [PATCH v2 1/6] gnu: Add python-roman BonfaceKilz
2021-04-14 20:54   ` [bug#47593] [PATCH v2 2/6] gnu: Add python-setuptools-declarative-requirements BonfaceKilz
2021-04-14 20:54   ` [bug#47593] [PATCH v2 3/6] gnu: Add python-pytest-helpers-namespace BonfaceKilz
2021-04-14 20:55   ` [bug#47593] [PATCH v2 4/6] gnu: Add python-uqbar BonfaceKilz
2021-04-14 20:55   ` [bug#47593] [PATCH v2 5/6] gnu: Add python-quicktions BonfaceKilz
2021-04-14 20:55   ` [bug#47593] [PATCH v2 6/6] gnu: Add abjad BonfaceKilz
2021-04-15 11:35   ` bug#47593: [PATCH v2 0/6] gnu: python-xyz: Add python-abjad Efraim Flashner
2021-04-15 13:32     ` [bug#47593] " Bonface Munyoki K.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86fsztoqkg.fsf@bonfacemunyoki.com \
    --to=me@bonfacemunyoki.com \
    --cc=47593@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=jgart@dismail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.