From: Sarah Morgensen <iskarian@mgsn.dev>
To: phodina <phodina@protonmail.com>
Cc: 49619@debbugs.gnu.org, control@debbugs.gnu.org
Subject: [bug#49619] [PATCH 1/2] Add pirate-get
Date: Tue, 20 Jul 2021 19:53:37 -0700 [thread overview]
Message-ID: <86bl6wtm1a.fsf@mgsn.dev> (raw)
In-Reply-To: <JuV3kXY4ae-0f4PzOqwU4h0_Vh24XCQbm0P3uWqIKZ_-_7hOqSjxqsSHPpVdGA1OPcVRuyq0GT5UNjV_a8ZrDHuaZmNbh81jQzI644BmQR8=@protonmail.com> (phodina@protonmail.com's message of "Sun, 18 Jul 2021 11:36:02 +0000")
merge 49619 49620
thanks
Hello,
Thanks for the patch. Please note that when submitting patchsets, only
the first patch should be sent to guix-patches@gnu.org; the rest should
be sent to the generated bug number, in this case 49619@debbugs.gnu.org,
in reply to the first email. You can find information about contributing
at:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html
I also have a few suggestions so your patch can be accepted.
phodina <phodina@protonmail.com> writes:
> Add pkg veryprettytable as a dependency for pkg pirate-get
>
> ---
Commit messages should follow the ChangeLog format; see the commit
history for examples. For example, this commit message would look like:
--8<---------------cut here---------------start------------->8---
gnu: Add python-veryprettytable.
* gnu/packages/python-xyz.scm (python-veryprettytable): New variable.
--8<---------------cut here---------------end--------------->8---
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index d8c3fbec07..40b93c4b30 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -1754,6 +1754,30 @@ helpers.")
> (properties `((python2-variant . ,(delay python2-humanfriendly))))
> (license license:expat)))
>
> +(define-public python-veryprettytable
> + (package
> + (name "python-veryprettytable")
> + (version "0.8.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "veryprettytable" version))
> + (sha256
> + (base32
> + "1k1rifz8x6qcicmx2is9vgxcj0qb2f5pvzrp7zhmvbmci3yack3f"))))
> + (build-system python-build-system)
> + (propagated-inputs
> + `(("python-colorama" ,python-colorama)
> + ("python-termcolor" ,python-termcolor)))
> + (home-page
> + "https://github.com/smeggingsmegger/VeryPrettyTable")
> + (synopsis
> + "A visually appealing ASCII table output format")
Avoid starting synopses and descriptions with articles. "Visually
appealing..." would be fine.
> + (description
> + "A simple Python library for easily displaying tabular data in a visually
> +appealing ASCII table format")
Descriptions typically start: "VeryPrettyTable is a simple..."
The description for pirate-get should probably start "Pirate-get is
a..." or "@code{pirate-get} is a..."
> + (license license:bsd3)))
This should be license:bsd-3.
> +
> (define-public python2-humanfriendly
> (let ((base (package-with-python2
> (strip-python2-variant python-humanfriendly))))
> --
> 2.31.1
You should also add your copyright at the top of the file, below all the
others.
Please use `--reroll-count=` when generating revised patchsets and
`--to=49169@debbugs.gnu.org --in-reply-to=<original patch's Message-ID>`
when sending.
--
Sarah
next prev parent reply other threads:[~2021-07-21 2:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 11:36 [bug#49619] [PATCH 1/2] Add pirate-get phodina via Guix-patches via
2021-07-21 2:53 ` Sarah Morgensen [this message]
2021-07-22 12:17 ` phodina via Guix-patches via
2021-07-22 12:22 ` [bug#49619] [PATCH 2/2] " phodina via Guix-patches via
2021-09-18 8:07 ` [bug#49619] Patch status phodina via Guix-patches via
2021-09-18 12:44 ` [bug#49619] [PATCH v3 1/2] gnu: Add python-very-pretty-table phodina via Guix-patches via
2021-09-18 12:45 ` [bug#49619] [PATCH v3 2/2] gnu: Add python-pirate-get phodina via Guix-patches via
2021-11-08 16:52 ` phodina via Guix-patches via
2021-09-22 3:21 ` [bug#49619] [PATCH v3 1/2] gnu: Add python-very-pretty-table Sarah Morgensen
2021-09-27 22:41 ` phodina via Guix-patches via
2022-10-30 20:22 ` [bug#49619] Upstream or close the ticket phodina via Guix-patches via
2022-10-30 22:23 ` jgart via Guix-patches via
2022-12-25 18:01 ` phodina via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bl6wtm1a.fsf@mgsn.dev \
--to=iskarian@mgsn.dev \
--cc=49619@debbugs.gnu.org \
--cc=control@debbugs.gnu.org \
--cc=phodina@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.