From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: how to customize mirror list used in custom channels?
Date: Tue, 29 Nov 2022 20:02:45 +0100 [thread overview]
Message-ID: <86bkop7fe2.fsf@gmail.com> (raw)
In-Reply-To: <87o7sq6tki.fsf@gnu.org>
Hi,
On Tue, 29 Nov 2022 at 09:41, Ludovic Courtès <ludo@gnu.org> wrote:
> The more I write, the closer I get to an actual implementation. :-)
> If ‘url-fetch’ takes a #:mirrors, that should allow us to extend the set
> of mirrors quite conveniently, along the lines of:
>
> (define (my-url-fetch . args)
> (apply url-fetch (append args '(#:mirrors …))))
Well, the ’url-fetch’ defined in (guix build download) already takes
#:mirrors, no?
--8<---------------cut here---------------start------------->8---
(define* (url-fetch url file
#:key
(timeout 10) (verify-certificate? #t)
(mirrors '()) (content-addressed-mirrors '())
(disarchive-mirrors '())
(hashes '())
print-build-trace?)
--8<---------------cut here---------------end--------------->8---
So, I guess you are talking about ’url-fetch*’ from (guix download) and
exported as ’url-fetch’. Right? The one which put the bits in the
store. :-)
Does something like that would make sense?
--8<---------------cut here---------------start------------->8---
diff --git a/guix/download.scm b/guix/download.scm
index 2e9ecb43fc..2497ea0f75 100644
--- a/guix/download.scm
+++ b/guix/download.scm
@@ -499,6 +499,7 @@ (define %download-fallback-test
(define* (url-fetch* url hash-algo hash
#:optional name
#:key (system (%current-system))
+ (mirrors %mirrors)
(guile (default-guile))
executable?)
"Return a fixed-output derivation that fetches data from URL (a string, or a
@@ -519,7 +520,8 @@ (define file-name
(_
(basename url))))
- (let ((uri (and (string? url) (string->uri url))))
+ (let ((uri (and (string? url) (string->uri url)))
+ (mirror-file (plain-file "mirrors" (object->string mirrors))))
(if (or (and (string? url) (not uri))
(and uri (memq (uri-scheme uri) '(#f file))))
(interned-file (if uri (uri-path uri) url)
@@ -540,7 +542,7 @@ (define file-name
#:hash-algo hash-algo
#:hash hash
#:executable? executable?
- #:mirrors %mirror-file
+ #:mirrors mirror-file
#:content-addressed-mirrors
(match (%download-fallback-test)
((or #f 'content-addressed-mirrors)
--8<---------------cut here---------------end--------------->8---
This change would a world rebuild, right?
Last, note that ’download-to-store’ uses %mirrors so it seems
straightforward here to add ’#:key (mirrors %mirrors)’, I guess.
Cheers,
simon
next prev parent reply other threads:[~2022-11-29 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 8:42 how to customize mirror list used in custom channels? zimoun
2022-11-26 11:11 ` Ludovic Courtès
2022-11-27 12:09 ` zimoun
2022-11-28 10:49 ` Ludovic Courtès
2022-11-28 12:52 ` zimoun
2022-11-29 8:41 ` Ludovic Courtès
2022-11-29 19:02 ` zimoun [this message]
2022-12-02 9:01 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bkop7fe2.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.