From: Brice Waegeneire <brice@waegenei.re>
To: 41080@debbugs.gnu.org
Subject: [bug#41080] [PATCH] doc: cookbook: add entry for Wireguard VPN connection on Guix System
Date: Mon, 11 May 2020 19:37:08 +0000 [thread overview]
Message-ID: <84b581259bee7a91a1c1676efc9c30d6@waegenei.re> (raw)
In-Reply-To: <20200504154915.3963-1-sirmacik@wioo.waw.pl>
Hello Marcin,
Thank you for the patch!
> +@lisp
> +(use-modules (gnu))
> +(use-package-modules vpn)
> +
> +(operating-system
> +;; …
> +(packages
> + (append (map specification->package
> + '("wireguard-linux-compat" "wireguard-tools"))
> + %base-packages)))
> +@end lisp
There is no use to put "wireguard-linux-compat" in the packages field,
instead it should be in the kernel-loadable-modules field to be
loadable by modprobe and an in the kernel-module-loader-service for
being autoloaded at boot with an entry like:
“(simple-service 'wireguard-module kernel-module-loader-service-type
'("wireguard"))”
Also note that all the above is only necessary with a Linux-libre
kernel >5.6, after that wireguard is built into it.
https://issues.guix.info/issue/41192 should fix the wg-quick issue,
can you try it and update the documentation accordingly. About this
script can you specify that it's a “very quick and dirty bash script”
as wireguard's docs says and that it should probably be avoided except
for testing and such.
Also can you resend the patch as a git-patch instead of a plain diff,
you can find the related guidelines in the manual[0].
[0]:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html#Submitting-Patches
Cheers,
- Brice
next prev parent reply other threads:[~2020-05-11 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 15:49 [bug#41080] [PATCH] doc: cookbook: add entry for Wireguard VPN connection on Guix System Marcin Karpezo
2020-05-11 19:37 ` Brice Waegeneire [this message]
2020-05-26 22:07 ` [bug#41080] [PATCH v2] Add wireguard connection instructions to cookbook Marcin Karpezo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84b581259bee7a91a1c1676efc9c30d6@waegenei.re \
--to=brice@waegenei.re \
--cc=41080@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.