From: Martin Becze <mjbecze@riseup.net>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 39931@debbugs.gnu.org
Subject: [bug#39931] [PATCH] gnu: Added emacs-org-journal
Date: Fri, 6 Mar 2020 11:05:07 -0500 [thread overview]
Message-ID: <8283ce01-fb0a-9591-f8bd-3cf36e8c4332@riseup.net> (raw)
In-Reply-To: <87a74uk11v.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 2245 bytes --]
Thanks for the review Nicolas!
Attached is an updated patch.
On 3/5/20 3:18 PM, Nicolas Goaziou wrote:
> Hello,
>
> Martin Becze <mjbecze@riseup.net> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-org-journal): New Variable.
>
> Thank you!
>
>> +(define-public emacs-org-journal
>> + (package
>> + (name "emacs-org-journal")
>> + (version "2.0.0")
>> + (home-page "https://github.com/bastibe/org-journal")
>
> Usually, `home-page' is lower in the package definition, right above `synopsis'.
>
>> + (source
>> + (origin
>> + (method git-fetch)
>> + (uri (git-reference
>> + (url home-page)
>
> It may be just me, but I'm not a big fan of this trick, because it binds
> two information that might be unrelated at some point. I suggest to use
> the full URL instead.
>
> OTOH, the above is not a strong argument either, so it's up to you.
>
>> + (commit version)))
>> + (file-name (git-file-name name version))
>> + (sha256
>> + (base32
>> + "18dqd0jy2x530lk0h4fcn9cld9qh4w7b3vxa60fpiia628vsv1dg"))))
>> + (build-system emacs-build-system)
>> + (synopsis "A simple org-mode based journaling mode")
>
> I suggest "Simple Org mode based journaling mode". In any case, I think
> "guix lint" complains when a synopsis starts with an article.
>
>> + (description "@code{org-journal} maintains a set of files, depending on the value
>> + of @{org-journal-file-type}, a file represents a day, week, month or year. When
>> +@code{org-journal-file-type} is set to =’daily=, each file represent a day. In case
>> +@{org-journal-file-type} is set to =’weekly=, a file represents
>> a week, etc.
>
> "Org Journal maintains a set of files, which may represent a day,
> a week, a month or a year."
>
> IOW, I think description should not leak the innards of the package.
>
>> + Convenient bindings allow the creation of journal records in the current daily,
>> + weekly, monthly or yearly file and search within all records or specified time
>> + intervals. All records can be browsed and searched from the Emacs Calendar for
>> + convenience.")
>
> You need to add two spaces after full stops.
>
> Could you send an updated patch?
>
> Regards,
>
[-- Attachment #2: v2-0001-gnu-Added-emacs-org-journal.patch --]
[-- Type: text/x-patch, Size: 2320 bytes --]
From a767bfa8094be4bcd5fcdca9c4f4862114b5a07a Mon Sep 17 00:00:00 2001
From: Martin Becze <mjbecze@riseup.net>
Date: Thu, 5 Mar 2020 12:40:42 -0500
Subject: [PATCH v2] gnu: Added emacs-org-journal
* gnu/packages/emacs-xyz.scm (emacs-org-journal): New Variable.
---
gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 19c4ed7571..f20ea14174 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -60,6 +60,7 @@
;;; Copyright © 2020 Paul Garlick <pgarlick@tourbillion-technology.com>
;;; Copyright © 2020 Robert Smith <robertsmith@posteo.net>
;;; Copyright © 2020 Evan Straw <evan.straw99@gmail.com>
+;;; Copyright © 2020 Martin Becze <mjbecze@riseup.net>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -21732,3 +21733,30 @@ supports generation of phonetic and numeric passwords.")
Separated Value) files. It follows the format as defined in RFC 4180 \"Common
Format and MIME Type for CSV Files\" (@url{http://tools.ietf.org/html/rfc4180}).")
(license license:gpl3+)))
+
+(define-public emacs-org-journal
+ (package
+ (name "emacs-org-journal")
+ (version "2.0.0")
+ (home-page "https://github.com/bastibe/org-journal")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url home-page)
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "18dqd0jy2x530lk0h4fcn9cld9qh4w7b3vxa60fpiia628vsv1dg"))))
+ (build-system emacs-build-system)
+ (synopsis "A simple org-mode based journaling mode")
+ (description "@code{org-journal} maintains a set of files, depending on the value
+ of @{org-journal-file-type}, a file represents a day, week, month or year. When
+@code{org-journal-file-type} is set to =’daily=, each file represent a day. In case
+@{org-journal-file-type} is set to =’weekly=, a file represents a week, etc.
+ Convenient bindings allow the creation of journal records in the current daily,
+ weekly, monthly or yearly file and search within all records or specified time
+ intervals. All records can be browsed and searched from the Emacs Calendar for
+ convenience.")
+ (license license:bsd-3)))
--
2.25.1
next prev parent reply other threads:[~2020-03-06 16:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 17:47 [bug#39931] [PATCH] gnu: Added emacs-org-journal Martin Becze
2020-03-05 20:18 ` Nicolas Goaziou
2020-03-06 16:05 ` Martin Becze [this message]
2020-03-07 18:23 ` Martin Becze
2020-03-08 10:24 ` bug#39931: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8283ce01-fb0a-9591-f8bd-3cf36e8c4332@riseup.net \
--to=mjbecze@riseup.net \
--cc=39931@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.