From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: John Kehayias <john.kehayias@protonmail.com>, 69495@debbugs.gnu.org
Cc: Raghav Gururajan <rg@raghavgururajan.name>,
Vivien Kraus <vivien@planete-kraus.eu>,
Efraim Flashner <efraim@flashner.co.il>,
Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: [bug#69495] [PATCH 0/2] gnu: cairo: Update to 1.18.0.
Date: Wed, 27 Mar 2024 18:52:58 +0100 [thread overview]
Message-ID: <80e01d3d4d6a8dab981fbe2d9792cdc87828b496.camel@gmail.com> (raw)
In-Reply-To: <877chontxw.fsf@protonmail.com>
Am Mittwoch, dem 27.03.2024 um 05:08 +0000 schrieb John Kehayias:
> Hello,
>
> Arg, I don't know if this ever was actually sent to the gnome-team!
> Also
> adding Efraim due to a librsvg issue (below).
>
> Apologies if it didn't go through originally (or if you are getting
> it
> again).
>
> On Sat, Mar 02, 2024 at 01:50 AM, John Kehayias wrote:
>
> > Hi gnome-team and guix,
> >
> > I'm cc'ing the gnome-team as this would normally fall to them, but
> > with their
> > pending merge and the builds upcoming on mesa-updates (libdrm,
> > which cairo
> > depends on), I think this will go on mesa-updates. The patch is
> > based on
> > master, not gnome-team. Still, thought it would be good to have a
> > review as
> > this was non-trivial. Thanks to lilyp on #guix for tips!
> >
> > Please see the patches to update cairo to the new release (after
> > many years!)
> > of 1.18.0. An update to python-pycairo was needed first. The end
> > result is
> > that our cairo package is quite a bit simpler as the defaults
> > include the tee
> > backend that we had enabled before. I removed all the old configure
> > flags and
> > propagated-inputs which were commented out and now obsolete.
> >
> > The docs require gtk-doc which depends on cairo. To break the cycle
> > cairo is
> > hidden (but exported) and built without docs, with the public
> > cairo-with-docs
> > including them. I followed what was done for glib with a similar
> > issue.
> >
> > I did not try too much enable tests, which may have been revamped?
> > The quick
> > look I took in the source docs suggested that it is very system
> > dependent
> > (reference images) though does run on their GitLab CI. When
> > enabling
> > test/ps2png.p/ps2png.c.o fails to build as it can't find cairo.h.
> > Perhaps it
> > needs to build tests in a phase after cairo has built and set in a
> > way to find
> > this just build version?
> >
> > Anyway, this built locally for me on x86_64. I built up to icecat,
> > which needs
> > the tee backend we previously manually enabled, and it built and
> > ran
> > successfully.
> >
> > Let me know of any issues or changes wanted or if someone wants to
> > take this
> > on a different branch. I think it makes sense on mesa-updates due
> > to the
> > libdrm update I will take there.
> >
> > Thanks!
> > John
> >
> >
> > John Kehayias (2):
> > gnu: python-pycairo: Update to 1.26.0.
> > gnu: cairo: Update to 1.18.0.
> >
> > gnu/local.mk | 2 -
> > gnu/packages/gtk.scm | 85 ++++++++++-----
> > ----
> > .../patches/cairo-CVE-2018-19876.patch | 37 --------
> > .../patches/cairo-CVE-2020-35492.patch | 49 -----------
> > 4 files changed, 47 insertions(+), 126 deletions(-)
> > delete mode 100644 gnu/packages/patches/cairo-CVE-2018-19876.patch
> > delete mode 100644 gnu/packages/patches/cairo-CVE-2020-35492.patch
> >
> >
> > base-commit: b386c11e7804e0b577411d930b60f1e0a4a0382c
> > prerequisite-patch-id: 2889be19c4a046760f2f608cefff987b11b65a31
> > --
> > 2.41.0
>
> I've applied this series locally and haven't run into issues in
> building (and trying a few random packages). Happy to take feedback
> before I push this to mesa-updates, and even then will be some time
> before the branch will be built to be merged to master. Other updates
> include mesa, sdl2, and vulkan.
I think mesa-updates would be the right place – gnome-team is quite
close to merge, so we can't do a world rebuild there right now.
Cheers
next prev parent reply other threads:[~2024-03-27 17:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 1:50 [bug#69495] [PATCH 0/2] gnu: cairo: Update to 1.18.0 John Kehayias via Guix-patches via
2024-03-02 1:53 ` [bug#69495] [PATCH 1/2] gnu: python-pycairo: Update to 1.26.0 John Kehayias via Guix-patches via
2024-03-02 1:53 ` [bug#69495] [PATCH 2/2] gnu: cairo: Update to 1.18.0 John Kehayias via Guix-patches via
2024-03-27 5:08 ` [bug#69495] [PATCH 0/2] " John Kehayias via Guix-patches via
2024-03-27 8:47 ` Efraim Flashner
2024-03-27 14:55 ` John Kehayias via Guix-patches via
2024-03-27 17:52 ` Liliana Marie Prikler [this message]
2024-04-18 4:41 ` bug#69495: " John Kehayias via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80e01d3d4d6a8dab981fbe2d9792cdc87828b496.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=69495@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=john.kehayias@protonmail.com \
--cc=maxim.cournoyer@gmail.com \
--cc=rg@raghavgururajan.name \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.