From: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
To: "J. Sims" <jtsims@protonmail.com>
Cc: 58236@debbugs.gnu.org
Subject: [bug#58236] [PATCH] gnu: genie: Add genie.
Date: Wed, 05 Oct 2022 12:34:05 +0200 [thread overview]
Message-ID: <77199596cf765478acdd1f7018107acc5e040d4e.camel@ist.tugraz.at> (raw)
In-Reply-To: <QiTVHqkwXeIqQexAgHAJPeHICRw1vrR6zWI5cyt0KqPrEP9z5QTjfHFuEawqsBZih5Rvzsxo7sjykYRpLcQwnmnb6xLXkovXkoesxWnEKsg=@protonmail.com>
Am Dienstag, dem 04.10.2022 um 19:37 +0000 schrieb J. Sims:
> (define-public genie
> + (let ((commit "b139103697bbb62db895e4cc7bfe202bcff4ff25")
> + (version "1167")
> + (revision "0"))
Do not let-bind version.
> + (package
> + (name "genie")
> + (version (git-version version revision commit))
> + (home-page "https://github.com/bkaradzic/genie")
home-page comes before synopsis and description...
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url home-page)
> + (commit commit)))
Don't pull it up so that you can "save" the url argument. Type url out
explicitly.
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> +
> "16plshzkyjjzpfcxnwjskrs7i4gg0qn92h2k0rbfl4a79fgmwvwv"))))
> + (build-system gnu-build-system)
> + (arguments
> + (list #:phases #~(modify-phases %standard-phases
> + (delete 'configure)
> + (replace 'install
> + (lambda _
> + (install-file "bin/linux/genie"
> + (string-append #$output
> "/bin")))))
Prefer saving horizontal space over vertical space.
> + #:tests? #f)) ;only manual tests
When it comes to software testing, there is no sequence of instructions
that only a human can carry out. Tests either exist or they don't and
in the case of GENie there at least formally exists a directory for
them.
> + (synopsis "Project generator tool")
Note that tool is superfluous here.
> + (description
> + "GENie is project generator tool. It generates projects from
> +Lua scripts, making applying the same settings for multiple projects
> easy. It
I'd simply write "GENie generates projects from Lua scripts, making it
easy to apply the same settings to multiple projects."
> +supports generating projects using GNU Makefiles; JSON Compilation
> Database;
> +Visual Studio 2010, 2012, 2013, 2015, 2017, and 2019; XCode; and
> experimentally
> +supports Ninja.")
We're not going to use proprietary software on our FSDG-compliant
system, so it's only Makefiles, JSON compilation databases and
experimental Ninja.
> + (license license:bsd-3))))
Cheers
next prev parent reply other threads:[~2022-10-05 10:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 22:15 [bug#58236] [PATCH] gnu: genie: Add genie J. Sims via Guix-patches via
2022-10-03 6:45 ` Liliana Marie Prikler
2022-10-04 19:37 ` J. Sims via Guix-patches via
2022-10-05 10:34 ` Liliana Marie Prikler [this message]
2022-10-06 1:06 ` J. Sims via Guix-patches via
2022-10-06 1:12 ` J. Sims via Guix-patches via
2022-10-09 20:20 ` bug#58236: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77199596cf765478acdd1f7018107acc5e040d4e.camel@ist.tugraz.at \
--to=liliana.prikler@ist.tugraz.at \
--cc=58236@debbugs.gnu.org \
--cc=jtsims@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.