all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
blob 72a1d1ecfa347b4f7e0d604c3490ede00c85e6bc 1736 bytes (raw)
name: gnu/packages/patches/tootle-Use-reason_phrase-instead-of-get_phrase.patch 	 # note: path name is non-authoritative(*)

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
 
From 858ee78fbebe161a4cdd707a469dc0f045211a51 Mon Sep 17 00:00:00 2001
From: Max Harmathy <harmathy@mailbox.org>
Date: Wed, 25 Aug 2021 13:05:58 +0200
Subject: [PATCH] Use reason_phrase instead of get_phrase

---
 src/Services/Cache.vala   | 2 +-
 src/Services/Network.vala | 7 +------
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/Services/Cache.vala b/src/Services/Cache.vala
index 2251697..2ed314e 100644
--- a/src/Services/Cache.vala
+++ b/src/Services/Cache.vala
@@ -88,7 +88,7 @@ public class Tootle.Cache : GLib.Object {
                 try {
                     var code = msg.status_code;
 					if (code != Soup.Status.OK) {
-					    var error = network.describe_error (code);
+					    var error = msg.reason_phrase;
 					    throw new Oopsie.INSTANCE (@"Server returned $error");
 					}
 
diff --git a/src/Services/Network.vala b/src/Services/Network.vala
index fa2839c..d0143b0 100644
--- a/src/Services/Network.vala
+++ b/src/Services/Network.vala
@@ -56,7 +56,7 @@ public class Tootle.Network : GLib.Object {
                 else if (status == Soup.Status.CANCELLED)
                     debug ("Message is cancelled. Ignoring callback invocation.");
                 else
-                    ecb ((int32) status, describe_error ((int32) status));
+                    ecb ((int32) status, msg.reason_phrase);
             });
         }
         catch (Error e) {
@@ -65,11 +65,6 @@ public class Tootle.Network : GLib.Object {
         }
     }
 
-	public string describe_error (uint code) {
-	    var reason = Soup.Status.get_phrase (code);
-		return @"$code: $reason";
-	}
-
     public void on_error (int32 code, string message) {
         warning (message);
         app.toast (message);

debug log:

solving 72a1d1ecfa ...
found 72a1d1ecfa in https://git.savannah.gnu.org/cgit/guix.git

(*) Git path names are given by the tree(s) the blob belongs to.
    Blobs themselves have no identifier aside from the hash of its contents.^

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.