From: Maxime Devos <maximedevos@telenet.be>
To: Julien Lepiller <julien@lepiller.eu>, 54239@debbugs.gnu.org
Subject: [bug#54239] [PATCH] gnu: Add cross-clang.
Date: Thu, 03 Mar 2022 17:40:36 +0100 [thread overview]
Message-ID: <70c3446488f9b76479f4f989c351403c461369d1.camel@telenet.be> (raw)
In-Reply-To: <20220303170252.3caec0a6@tachikoma.lepiller.eu>
[-- Attachment #1: Type: text/plain, Size: 2792 bytes --]
Julien Lepiller schreef op do 03-03-2022 om 17:02 [+0100]:
> Hi Guix!
>
> This small patch series adds cross-clang, a cross-compiler version of
> clang. Clang doesn't really make a distinction between a native and a
> cross-build, it is already a cross-compiler, but this ensures that:
>
> 1. it actually works
> 2. it targets (%current-target-architecture) by default
Do you mean (%current-target-system)?
Also, WDYT of making 'cross-clang' a memoising procedure, such
that there's only one package object for a cross-clang of a fixed
target system (and version)?
> (native-inputs
> - (list clang llvm))
> + (list (if (%current-target-system)
> + (cross-clang (%current-target-system) #:clang clang-9)
> + clang-9)))
Probably a few other packages built with clang need such a thing as well.
How about making doing the right thing a bit easier? Suggestion: introduce
a 'clang-for-target' procedure, automatically returning the right clang:
(define (clang-for-target #:optional (clang clang))
(if (%current-target-system)
(cross-clang [...])
clang)) ; not cross-compiling
then packages just need to do
(native-inputs (list (clang-for-target) libfoo libbar ...))
The rest of the series ensures that libcxx and libcxxabi can be
cross-compiled with it.
Customarily, cross-compilers are named $TARGET-foo. WDYT of
renaming the clang binary to '$TARGET-clang', such that a package
can have both a native clang and a cross-clang in native-inputs if desired?
Also, Autoconf looks for $TARGET-compiler, where compiler is at least gcc,
but possibly also clang
And perhaps the package name can be changed '$TARGET-clang' like done for gcc?
> + ;; Support the same variables as clang, even in cross-compilation
> + ;; context.
> + ;; Clang does not make a difference between native and
> + ;; cross-compilation.
Upstream clang doesn't, but this is in a 'cross-clang' procedure,
so I think it would make sense for Guix' cross-clang to ignore
LIBRARY_PATH and only use CROSS_LIBRARY_PATH. Mixing up
C_INCLUDE_PATH and CROSS_C_INCLUDE_PATH (& friends) is unlikely
to lead anything good, e.g. include/bits/setjmp.h is architecture-dependent.
> + (files '("lib" "lib64"))))
I don't think Guix does a "lib" / "lib64" split, "lib" might
be sufficient. At least, there are a few comments like
;; Force powerpc libdir to be /lib and not /lib64
in Guix (though the gcc packages still includes "lib64" but
maybe that's only due to historical reasons).
How does this patch series interact with 'with-c-toolchain'?
Would "guix build hello --target=aarch64-linux-gnu --with-c-toolchain=..."
succesfully compile 'hello' with clang?
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-03-03 16:44 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 16:02 [bug#54239] [PATCH] gnu: Add cross-clang Julien Lepiller
2022-03-03 16:07 ` [bug#54239] [PATCH 1/5] gnu: Add cross-llvm Julien Lepiller
2022-03-03 16:07 ` [bug#54239] [PATCH 2/5] gnu: Add cross-clang Julien Lepiller
2022-03-03 16:07 ` [bug#54239] [PATCH 3/5] gnu: libcxx: Allow cross-compilation Julien Lepiller
2022-03-03 16:07 ` [bug#54239] [PATCH 4/5] gnu: libcxxabi-6: " Julien Lepiller
2022-03-03 16:07 ` [bug#54239] [PATCH 5/5] gnu: Add libcxxabi-9 Julien Lepiller
2022-03-03 16:40 ` Maxime Devos [this message]
2022-03-03 18:35 ` [bug#54239] [PATCH] gnu: Add cross-clang Julien Lepiller
2022-03-03 18:59 ` Maxime Devos
2022-03-03 21:11 ` Julien Lepiller
2022-03-04 20:05 ` Maxime Devos
2022-03-03 20:51 ` Pierre Langlois
2022-03-03 21:20 ` Julien Lepiller
2022-03-04 9:59 ` [bug#54239] [PATCH v2 1/5] gnu: Add cross-llvm Julien Lepiller
2022-03-04 9:59 ` [bug#54239] [PATCH v2 2/5] gnu: Add cross-clang Julien Lepiller
2022-03-04 19:53 ` Maxime Devos
2022-03-04 19:54 ` Maxime Devos
2022-03-05 8:30 ` Julien Lepiller
2022-03-04 19:56 ` Maxime Devos
2022-03-04 20:00 ` Maxime Devos
2022-03-05 16:05 ` Pierre Langlois
2022-03-04 9:59 ` [bug#54239] [PATCH v2 3/5] gnu: libcxx: Allow cross-compilation Julien Lepiller
2022-03-04 9:59 ` [bug#54239] [PATCH v2 4/5] gnu: libcxxabi-6: " Julien Lepiller
2022-03-04 9:59 ` [bug#54239] [PATCH v2 5/5] gnu: Add libcxxabi-9 Julien Lepiller
2022-03-04 19:50 ` Maxime Devos
2022-05-21 13:41 ` [bug#54239] [PATCH] gnu: Add cross-clang Ludovic Courtès
2022-07-16 19:44 ` Julien Lepiller
2022-07-16 19:47 ` [bug#54239] [PATCH v3 01/10] guix: Add build-system transformation for target Julien Lepiller
2022-07-16 19:47 ` [bug#54239] [PATCH v3 02/10] gnu: clang-runtime: Fix cross-compilation Julien Lepiller
2022-07-16 19:48 ` [bug#54239] [PATCH v3 03/10] gnu: llvm-9: " Julien Lepiller
2022-07-16 19:48 ` [bug#54239] [PATCH v3 04/10] gnu: Add cross-llvm Julien Lepiller
2022-07-16 19:48 ` [bug#54239] [PATCH v3 05/10] gnu: Add cross-clang Julien Lepiller
2022-07-16 19:48 ` [bug#54239] [PATCH v3 06/10] gnu: libcxx: Allow cross-compilation Julien Lepiller
2022-07-16 19:48 ` [bug#54239] [PATCH v3 07/10] gnu: libcxxabi-6: " Julien Lepiller
2022-07-16 19:48 ` [bug#54239] [PATCH v3 08/10] gnu: Add libcxxabi-9 Julien Lepiller
2022-07-16 19:48 ` [bug#54239] [PATCH v3 09/10] gnu: Add libcxx-12 Julien Lepiller
2022-07-16 19:48 ` [bug#54239] [PATCH v3 10/10] gnu: Add libcxxabi-12 Julien Lepiller
2022-07-19 19:54 ` [bug#54239] [PATCH] gnu: Add cross-clang Maxime Devos
2022-07-19 20:42 ` Julien Lepiller
2022-03-04 19:34 ` [bug#54239] [PATCH v2 1/5] gnu: Add cross-llvm Pierre Langlois
2022-03-05 8:24 ` Julien Lepiller
2022-03-05 13:02 ` Pierre Langlois
2022-03-05 14:00 ` Pierre Langlois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70c3446488f9b76479f4f989c351403c461369d1.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=54239@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.