all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Simon South <simon@simonsouth.net>
To: 53779@debbugs.gnu.org
Subject: [bug#53779] [PATCH 2/5] gnu: iwd: Build from Git sources.
Date: Fri,  4 Feb 2022 10:43:33 -0500	[thread overview]
Message-ID: <6ec2d0a5b769bdbd66a99f9c0240363964f66ee0.1643988584.git.simon@simonsouth.net> (raw)
In-Reply-To: <cover.1643988584.git.simon@simonsouth.net>

* gnu/packages/networking.scm (iwd)[source]: Use "git-fetch" and
"git-file-name".
[inputs]: Add ell source code.
[native-inputs]: Add autoconf, automake, libtool.
[arguments]<#:phases>: Add "copy-ell-header-files" phase to copy shared header
files from ell source into source tree.
---
 gnu/packages/networking.scm | 38 ++++++++++++++++++++++++++++---------
 1 file changed, 29 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 064248600e..dc42ec4d73 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -47,6 +47,7 @@
 ;;; Copyright © 2021 Milkey Mouse <milkeymouse@meme.institute>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
 ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
+;;; Copyright © 2022 Simon South <simon@simonsouth.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3568,20 +3569,25 @@ (define-public iwd
     (name "iwd")
     (version "1.20")
     (source (origin
-              ;; FIXME: We're using the bootstrapped sources because
-              ;; otherwise using an external ell library is impossible.
-              ;; How to bootstrap with Guix?
-              (method url-fetch)
-              (uri (string-append "https://www.kernel.org/pub/linux/network"
-                                  "/wireless/iwd-" version ".tar.xz"))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.kernel.org/pub/scm/network/wireless/iwd.git")
+                    (commit version)))
+              (file-name (git-file-name name version))
               (sha256
                (base32
-                "03q5scahyg86h4bdxqxm32shyssgpmfp5b3183j01ig7mg6f4lbx"))))
+                "0xlbnsgw9giakfj0xr526i7mcwyaryb18g66mv90njnrm8radjhr"))))
     (build-system gnu-build-system)
     (inputs
-     (list dbus ell readline))
+     (list dbus ell (package-source ell) readline))
     (native-inputs
-     (list pkg-config python python-docutils openssl))
+     (list autoconf
+           automake
+           libtool
+           pkg-config
+           python
+           python-docutils
+           openssl))
     (arguments
      `(#:configure-flags
        (let ((dbus (assoc-ref %outputs "out")))
@@ -3596,6 +3602,20 @@ (define-public iwd
                               dbus "/share/dbus-1/system-services")))
        #:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'copy-ell-header-files
+           ;; Copy into the source tree two of ell's private header files that
+           ;; it shares with iwd, as is required to build with the
+           ;; "--enable-external-ell" configure option.
+           ;; See the definition of "ell_shared" in iwd's Makefile.am.
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((ell-header-dir (search-input-directory inputs "/ell"))
+                   (target-dir "ell"))
+               (mkdir target-dir)
+               (for-each
+                (lambda (file-name)
+                  (copy-file (string-append ell-header-dir "/" file-name)
+                             (string-append target-dir "/" file-name)))
+                '("asn1-private.h" "useful.h")))))
          (add-after 'configure 'patch-Makefile
            (lambda _
              (substitute* "Makefile"
-- 
2.34.0





  parent reply	other threads:[~2022-02-04 15:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04 15:41 [bug#53779] [PATCH 0/5] gnu: iwd: Build from Git; update to 1.23 Simon South
2022-02-04 15:43 ` [bug#53779] [PATCH 1/5] gnu: iwd: Remove input labels Simon South
2022-02-06 10:07   ` Maxime Devos
2022-02-04 15:43 ` Simon South [this message]
2022-02-04 15:43 ` [bug#53779] [PATCH 3/5] gnu: ell: " Simon South
2022-02-04 15:43 ` [bug#53779] [PATCH 4/5] gnu: ell: Update to 0.48 Simon South
2022-02-04 15:43 ` [bug#53779] [PATCH 5/5] gnu: iwd: Update to 1.23 Simon South
2022-02-07 14:26 ` [bug#53779] [PATCH v2 0/6] gnu: iwd: Build from Git; update to 1.24 Simon South
2022-02-07 14:26   ` [bug#53779] [PATCH 1/6] gnu: iwd: Remove input labels Simon South
2022-02-07 14:26   ` [bug#53779] [PATCH v2 2/6] gnu: iwd: Remove reference to %outputs Simon South
2022-02-07 14:26   ` [bug#53779] [PATCH v2 3/6] gnu: iwd: Build from Git sources Simon South
2022-02-07 14:26   ` [bug#53779] [PATCH v2 4/6] gnu: ell: Remove input labels Simon South
2022-02-07 14:26   ` [bug#53779] [PATCH v2 5/6] gnu: ell: Update to 0.48 Simon South
2022-02-08 22:48     ` [bug#53779] [PATCH 0/5] gnu: iwd: Build from Git; update to 1.23 Ludovic Courtès
2022-02-09 14:51       ` Simon South
2022-02-09 14:54         ` [bug#53779] [PATCH] gnu: ell: Disable parallel tests Simon South
2022-02-10 20:52           ` Ludovic Courtès
2022-02-07 14:26   ` [bug#53779] [PATCH v2 6/6] gnu: iwd: Update to 1.24 Simon South
2022-02-08 12:35   ` bug#53779: [PATCH 0/5] gnu: iwd: Build from Git; update to 1.23 Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ec2d0a5b769bdbd66a99f9c0240363964f66ee0.1643988584.git.simon@simonsouth.net \
    --to=simon@simonsouth.net \
    --cc=53779@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.