From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: rg@raghavgururajan.name, 63499-done@debbugs.gnu.org
Subject: bug#63499: [PATCH gnome-team 3/3] gnu: gtksourceview: Fix build.
Date: Sat, 27 May 2023 16:25:44 +0200 [thread overview]
Message-ID: <6eb778c87e3c661c50a289f6a05cbbfe02801e65.camel@gmail.com> (raw)
In-Reply-To: <87bkiltm4z.fsf@gmail.com>
Am Montag, dem 15.05.2023 um 15:44 -0400 schrieb Maxim Cournoyer:
> Hi,
>
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>
> > Am Montag, dem 15.05.2023 um 09:49 -0400 schrieb Maxim Cournoyer:
> > > Hello,
> > >
> > > Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> > >
> > > > * gnu/packages/gtk.scm (gtksourceview)[#:phases]<pre-check>:
> > > > Set
> > > > “GDK_BACKEND”
> > > > and “GTK_A11Y”.
> > > > ---
> > > > gnu/packages/gtk.scm | 3 +++
> > > > 1 file changed, 3 insertions(+)
> > > >
> > > > diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> > > > index de45eb3870..7d76610293 100644
> > > > --- a/gnu/packages/gtk.scm
> > > > +++ b/gnu/packages/gtk.scm
> > > > @@ -616,6 +616,9 @@ (define-public gtksourceview
> > > > ;; Tests require a running X server.
> > > > (system (string-append Xvfb " :1 &"))
> > > > (setenv "DISPLAY" ":1")
> > > > + ;; For GTK
> > >
> > > Nitpick: Add a full stop (period) for standalone comments.
> > > Perhaps
> > > expound how these environment variables are useful to set ('For
> > > GTK'
> > > leaves me wondering, as 'gtksourceview' already seems GTK-
> > > focused).
> > Full disclosure, I don't quite understand what's wrong here myself,
> > but
> > with the upgrade to GTK 4.10, tests fail
> > - due to GDK_BACKEND not being said for ??? reason
> > - due to GTK_A11Y because GTK tries to spawn dbus and fails to
> > connect.
> >
> > >
> > If there's a better wording for that, I'm all ears :)
>
> Perhaps above setenv "GTK_BACKEND" mention "XXX: To avoid failures in
> tests." and then above GTK_A11Y mention "Otherwise, GTK tries to
> spawn D-Bus and fails to connect."
>
> This captures everything you know; I think it's an improvement.
Reworded a little and pushed with GStreamer 1.22.3.
Cheers
prev parent reply other threads:[~2023-05-27 14:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-14 10:35 [bug#63499] [PATCH gnome-team 0/3] To GTK and beyond Liliana Marie Prikler
2023-04-16 5:47 ` [bug#63499] [PATCH gnome-team 1/3] gnu: gst-plugins-base: Fix build Liliana Marie Prikler
2023-05-15 13:46 ` Maxim Cournoyer
2023-05-15 19:32 ` Liliana Marie Prikler
2023-05-13 18:50 ` [bug#63499] [PATCH gnome-team 2/3] gnu: gtk: Update to 4.10.3 Liliana Marie Prikler
2023-05-15 13:47 ` Maxim Cournoyer
2023-05-13 20:27 ` [bug#63499] [PATCH gnome-team 3/3] gnu: gtksourceview: Fix build Liliana Marie Prikler
2023-05-15 13:49 ` Maxim Cournoyer
2023-05-15 18:27 ` Liliana Marie Prikler
2023-05-15 19:44 ` Maxim Cournoyer
2023-05-27 14:25 ` Liliana Marie Prikler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eb778c87e3c661c50a289f6a05cbbfe02801e65.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=63499-done@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.