all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Vinicius Monego <monego@posteo.net>
To: Stephen Paul Weber <singpolyma@singpolyma.net>, 51675@debbugs.gnu.org
Subject: [bug#51675] [PATCH 2/5] gnu: python-twisted: Update to 21.7.0
Date: Fri, 12 Nov 2021 17:53:06 +0000	[thread overview]
Message-ID: <69058da8cb8ffd6004857e7c5eff89a3a50aa00e.camel@posteo.net> (raw)
In-Reply-To: <20211108024520.49594-2-singpolyma@singpolyma.net>

Hi,

Em dom, 2021-11-07 às 21:45 -0500, Stephen Paul Weber escreveu:
> * gnu/packages/python-xyz.scm (python-twisted): Update to 21.7.0.
> [propagated-inputs]: Add python-typing-extensions, python-attrs, and
> python-service-identity.
> ---

I did not try to build the series, I will comment based on some
impressions first.

>  gnu/packages/python-xyz.scm | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-
> xyz.scm
> index 639945c278..96718c7c18 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -15105,22 +15105,31 @@ format.")
>  (define-public python-twisted
>    (package
>      (name "python-twisted")
> -    (version "19.7.0")
> +    (version "21.7.0")
>      (source (origin
>                (method url-fetch)
> -              (uri (pypi-uri "Twisted" version ".tar.bz2"))
> +              (uri (pypi-uri "Twisted" version))

This change should be described in the commit message.

>                (sha256
>                 (base32
> -               
> "17d3hnxv9qndagzz63mdpyk99xj63p9gq586vjn0rxk8cl197nym"))))
> +               
> "01lh225d7lfnmfx4f4kxwl3963gjc9yg8jfkn1w769v34ia55mic"))))
>      (build-system python-build-system)
>      (arguments
> -     '(#:tests? #f))                    ; FIXME: some tests fail
> +     '(#:tests? #f ; FIXME: some tests fail
> +       #:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'add-py3-var
> +                    (lambda _
> +                      (substitute* "src/twisted/python/compat.py"
> +                        (("_PY37PLUS = True")
> +                         "_PY37PLUS = True\n    _PY3 = True")))))))

This new phase should be described in the commit message.

>      (propagated-inputs
>       `(("python-zope-interface" ,python-zope-interface)
>         ("python-pyhamcrest" ,python-pyhamcrest)
>         ("python-incremental" ,python-incremental)
>         ("python-hyperlink" ,python-hyperlink)
>         ("python-constantly" ,python-constantly)
> +       ("python-typing-extensions" ,python-typing-extensions)
> +       ("python-attrs" ,python-attrs)
> +       ("python-service-identity" ,python-service-identity)
>         ("python-automat" ,python-automat)))

Could you also sort these inputs alphabetically?

>      (home-page "https://twistedmatrix.com/")
>      (synopsis "Asynchronous networking framework written in Python")






  reply	other threads:[~2021-11-12 17:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08  2:42 [bug#51675] Add python-wokkel, Jabber/XMPP module for Twisted Stephen Paul Weber
2021-11-08  2:45 ` [bug#51675] [PATCH 1/5] gnu: python-incremental: Update to 21.3.0 Stephen Paul Weber
2021-11-08  2:45   ` [bug#51675] [PATCH 2/5] gnu: python-twisted: Update to 21.7.0 Stephen Paul Weber
2021-11-12 17:53     ` Vinicius Monego [this message]
2021-11-08  2:45   ` [bug#51675] [PATCH 3/5] gnu: Add python-pydoctor Stephen Paul Weber
2021-11-12 18:02     ` Vinicius Monego
2021-11-08  2:45   ` [bug#51675] [PATCH 4/5] gnu: Add python-towncrier Stephen Paul Weber
2021-11-12 18:06     ` Vinicius Monego
2021-11-08  2:45   ` [bug#51675] [PATCH 5/5] gnu: Add python-wokkel Stephen Paul Weber
2021-11-12 18:14     ` Vinicius Monego
2021-11-12 18:21   ` [bug#51675] [PATCH 1/5] gnu: python-incremental: Update to 21.3.0 Vinicius Monego
2021-11-14  1:50 ` [bug#51675] [PATCH v2 " Stephen Paul Weber
2021-11-14  1:50   ` [bug#51675] [PATCH v2 2/5] gnu: python-twisted: Update to 21.7.0 Stephen Paul Weber
2021-11-14  1:50   ` [bug#51675] [PATCH v2 3/5] gnu: Add python-pydoctor Stephen Paul Weber
2021-11-14  1:50   ` [bug#51675] [PATCH v2 4/5] gnu: Add python-towncrier Stephen Paul Weber
2021-11-14  1:50   ` [bug#51675] [PATCH v2 5/5] gnu: Add python-wokkel Stephen Paul Weber
2022-01-14  0:48 ` [bug#51675] Add python-wokkel, Jabber/XMPP module for Twisted Stephen Paul Weber
2022-04-25  1:45   ` Vinicius Monego

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69058da8cb8ffd6004857e7c5eff89a3a50aa00e.camel@posteo.net \
    --to=monego@posteo.net \
    --cc=51675@debbugs.gnu.org \
    --cc=singpolyma@singpolyma.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.