From: Leo Prikler <leo.prikler@student.tugraz.at>
To: zimoun <zimon.toutoune@gmail.com>, Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 47069@debbugs.gnu.org
Subject: [bug#47069] [PATCH] etc: Run pre-push make in guix environment.
Date: Fri, 26 Mar 2021 11:11:59 +0100 [thread overview]
Message-ID: <60a9423555bdb4202c8684d3a5b5780b13422599.camel@student.tugraz.at> (raw)
In-Reply-To: <86lfaaba2m.fsf@gmail.com>
Am Freitag, den 26.03.2021, 09:20 +0100 schrieb zimoun:
> Hi Tobias,
>
> On Thu, 11 Mar 2021 at 15:42, Tobias Geerinckx-Rice <me@tobias.gr>
> wrote:
> > * etc/git/pre-push: Exec make in a guix development environment.
> > ---
> > The pre-push assumes you have make installed, which I didn't.
>
> How do you rebuild Guix before pushing?
If that's a problem for the script, you could add an explicit 'all'
target.
That said, I think, that many developers (myself included), who would
suffer from the problem mentioned by Tobias already run 'git push'
inside a guix environment. I know I do.
@Tobias: would it make sense to detect that case (via GUIX_ENVIRONMENT)
and only optionally construct the guix environment?
Regards,
Leo
prev parent reply other threads:[~2021-03-26 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 14:42 [bug#47069] [PATCH] etc: Run pre-push make in guix environment Tobias Geerinckx-Rice via Guix-patches via
2021-03-26 8:20 ` zimoun
2021-03-26 10:11 ` Leo Prikler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60a9423555bdb4202c8684d3a5b5780b13422599.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=47069@debbugs.gnu.org \
--cc=me@tobias.gr \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.