From: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
To: Felix Gruber <felgru@posteo.net>, 56886@debbugs.gnu.org
Subject: [bug#56886] [PATCH] gnu: queen-de: Fix build.
Date: Wed, 03 Aug 2022 10:27:11 +0200 [thread overview]
Message-ID: <5d0003ccaf8c29e87bb93a52c5c4a150e84b2c8b.camel@ist.tugraz.at> (raw)
In-Reply-To: <20220802130433.43696-1-felgru@posteo.net>
Am Dienstag, dem 02.08.2022 um 13:04 +0000 schrieb Felix Gruber:
> The German language version of the queen package does not contain a
> readme.txt file, but instead contains a file COPYING.
>
> * gnu/packages/games.scm (make-queen-package): Add readme-name
> argument.
> [arguments]: Use readme-name to install the readme file.
> (queen-de): Set readme-name to COPYING.
> (queen,queen-fr,queen-it): Set readme-name to readme.txt. This
> keeps
> the previous behavior.
> ---
> gnu/packages/games.scm | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 8b655cc0e4..8303afa633 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -9728,7 +9728,7 @@ Skorl. Maybe it would be an idea to try and
> escape...")
> (make-lure-package
> "lure-it" "it"
> "1ks6n39r1cllisrrh6pcr39swsdv7ng3gx5c47vaw71zzfr70hjj"))
>
> -(define (make-queen-package name file-prefix release language hash)
> +(define (make-queen-package name file-prefix release language
> readme-name hash)
> (package
> (name name)
> (version release)
> @@ -9756,7 +9756,7 @@ Skorl. Maybe it would be an idea to try and
> escape...")
> (let ((unzip (search-input-file %build-inputs
> "/bin/unzip")))
> (invoke unzip "-j" (assoc-ref %build-inputs "source")))
> (let ((doc (string-append share "/doc/" ,name "-"
> ,version)))
> - (install-file "readme.txt" doc))
> + (install-file ,readme-name doc))
> (install-file "queen.1c" data)
> (mkdir-p bin)
> (let ((bash (assoc-ref %build-inputs "bash")))
I'm pretty sure there ought to already be a phase that installs license
information if it exists. Thus, rather than parametrizing readme-name,
you should simply check whether the readme file exists.
For example
(for-each (lambda (file)
(when (file-exists? file) (install-file file doc)))
'("readme.txt" "README" "README.md"
"DAS-IST-SEHR-WICHTIG-LIESMICH!!!11!einself.txt")
Cheers
next prev parent reply other threads:[~2022-08-03 8:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 13:04 [bug#56886] [PATCH] gnu: queen-de: Fix build Felix Gruber
2022-08-03 8:27 ` Liliana Marie Prikler [this message]
2022-08-04 19:23 ` [bug#56886] [PATCH v2] " Felix Gruber
2022-08-05 6:15 ` Liliana Marie Prikler
2022-08-06 14:55 ` bug#56886: " Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d0003ccaf8c29e87bb93a52c5c4a150e84b2c8b.camel@ist.tugraz.at \
--to=liliana.prikler@ist.tugraz.at \
--cc=56886@debbugs.gnu.org \
--cc=felgru@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.