From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Vivien Kraus <vivien@planete-kraus.eu>, 69669@debbugs.gnu.org
Cc: rg@raghavgururajan.name, maxim.cournoyer@gmail.com
Subject: [bug#69669] [PATCH gnome-team 1/1] gnu: girara: Update to 0.4.3.
Date: Sat, 09 Mar 2024 09:24:20 +0100 [thread overview]
Message-ID: <5a6ad197dc94fafabc75784e9348134e2085ac33.camel@gmail.com> (raw)
In-Reply-To: <47c1519438f47449ee0f44ecbb4f5d8e443d627f.1709969886.git.vivien@planete-kraus.eu>
Am Samstag, dem 09.03.2024 um 08:33 +0100 schrieb Vivien Kraus:
> * gnu/packages/gtk.scm (girara): Update to 0.4.3.
> [native-inputs]: Drop labels.
> [propagated-inputs]: Add pango and json-glib.
> [arguments]: Convert to list of G-Expressions.
>
> Change-Id: I3c977cd33fa6d20fce3bb575ae2ad887b3061966
> ---
Since you are already mixing cosmetic and non-cosmetic changes, you can
also sort the fields. Inputs typically go after arguments.
> gnu/packages/gtk.scm | 53 +++++++++++++++++++++++-------------------
> --
> 1 file changed, 28 insertions(+), 25 deletions(-)
>
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index a00ce71b81..0c1b7fb5a0 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -2132,7 +2132,7 @@ (define-public perl-pango
> (define-public girara
> (package
> (name "girara")
> - (version "0.3.7")
> + (version "0.4.3")
> (source
> (origin
> (method git-fetch)
> @@ -2141,31 +2141,34 @@ (define-public girara
> (commit version)))
> (file-name (git-file-name name version))
> (sha256
> - (base32
> "0k93pi0lkf941vanvh1habm6n5wl1n63726j5kqxh34wdlv4mv4s"))))
> - (native-inputs `(("pkg-config" ,pkg-config)
> - ("check" ,check)
> - ("gettext" ,gettext-minimal)
> - ("glib:bin" ,glib "bin")
> - ("xorg-server" ,xorg-server-for-tests)))
> - ;; Listed in 'Requires.private' of 'girara.pc'.
> - (propagated-inputs (list gtk+))
> + (base32
> "0cbcs3810frgdmal5ia9pf3rk3k5h4xyzw1d2ia3rcg4nms5gcpx"))))
> + (native-inputs
> + (list pkg-config
> + check
> + gettext-minimal
> + `(,glib "bin")
> + xorg-server-for-tests))
> + ;; Listed in 'Requires.private' or 'Requires' of 'girara.pc'.
> + (propagated-inputs (list gtk+ pango json-glib))
I'd hazard a guess that some of these are already propagated through
gtk+.
> (arguments
> - `(#:phases (modify-phases %standard-phases
> - (add-before 'check 'start-xserver
> - ;; Tests require a running X server.
> - (lambda* (#:key inputs #:allow-other-keys)
> - (let ((xorg-server (assoc-ref inputs "xorg-
> server"))
> - (display ":1"))
> - (setenv "DISPLAY" display)
> -
> - ;; On busy machines, tests may take longer
> than
> - ;; the default of four seconds.
> - (setenv "CK_DEFAULT_TIMEOUT" "20")
> -
> - ;; Don't fail due to missing '/etc/machine-
> id'.
> - (setenv "DBUS_FATAL_WARNINGS" "0")
> - (zero? (system (string-append xorg-server
> "/bin/Xvfb "
> - display "
> &")))))))))
> + (list
> + #:phases
> + #~(modify-phases %standard-phases
> + (add-before 'check 'start-xserver
> + ;; Tests require a running X server.
> + (lambda* (#:key inputs #:allow-other-keys)
> + (let ((xorg-server (assoc-ref inputs "xorg-server"))
> + (display ":1"))
> + (setenv "DISPLAY" display)
> +
> + ;; On busy machines, tests may take longer than
> + ;; the default of four seconds.
> + (setenv "CK_DEFAULT_TIMEOUT" "20")
> +
> + ;; Don't fail due to missing '/etc/machine-id'.
> + (setenv "DBUS_FATAL_WARNINGS" "0")
> + (zero? (system (string-append xorg-server "/bin/Xvfb
> "
> + display " &")))))))))
> (build-system meson-build-system)
> (home-page "https://pwmt.org/projects/girara/")
> (synopsis "Library for minimalistic gtk+3 user interfaces")
Cheers
next prev parent reply other threads:[~2024-03-09 8:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 7:38 [bug#69669] [PATCH gnome-team 0/1] Update girara to 0.4.3 Vivien Kraus via Guix-patches via
2024-03-09 7:33 ` [bug#69669] [PATCH gnome-team 1/1] gnu: girara: Update " Vivien Kraus via Guix-patches via
2024-03-09 8:24 ` Liliana Marie Prikler [this message]
2024-03-09 8:58 ` [bug#69669] [PATCH gnome-team v3] gnu: girara: Build with json-glib Vivien Kraus via Guix-patches via
2024-03-12 13:28 ` Maxim Cournoyer
2024-03-16 11:05 ` Christopher Baines
2024-03-09 9:00 ` [bug#69669] [PATCH gnome-team v2 0/3] Update girara (better) Vivien Kraus via Guix-patches via
2024-03-09 7:33 ` [bug#69669] [PATCH gnome-team v2 2/3] gnu: girara: Update to 0.4.3 Vivien Kraus via Guix-patches via
2024-03-09 8:54 ` [bug#69669] [PATCH gnome-team v2 1/3] gnu: girara: Update style Vivien Kraus via Guix-patches via
2024-03-09 8:58 ` [bug#69669] [PATCH gnome-team v2 3/3] gnu: girara: Build with json-glib Vivien Kraus via Guix-patches via
2024-03-09 17:55 ` Maxim Cournoyer
2024-03-09 18:22 ` Vivien Kraus via Guix-patches via
2024-03-12 3:47 ` Maxim Cournoyer
2024-03-09 9:24 ` [bug#69669] [PATCH gnome-team v2 0/3] Update girara (better) Liliana Marie Prikler
2024-03-09 12:33 ` Vivien Kraus via Guix-patches via
2024-03-09 17:58 ` Maxim Cournoyer
2024-03-09 18:40 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a6ad197dc94fafabc75784e9348134e2085ac33.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=69669@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=rg@raghavgururajan.name \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.