all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Zhu Zihao" <all_but_last@163.com>
To: "Mark H Weaver" <mhw@netris.org>
Cc: guix-devel@gnu.org
Subject: Re:Re: IceCat-78.2 preview on 'wip-icecat-78' branch; need icedove-78.
Date: Mon, 28 Sep 2020 13:23:02 +0800 (CST)	[thread overview]
Message-ID: <57eb9030.45b5.174d32a0d89.Coremail.all_but_last@163.com> (raw)
In-Reply-To: <87y2kv6kmu.fsf@netris.org>

[-- Attachment #1: Type: text/plain, Size: 2201 bytes --]

Patches sent to http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43663


Please review, thanks!








At 2020-09-28 04:15:42, "Mark H Weaver" <mhw@netris.org> wrote:
>Hi,
>
>"Zhu Zihao" <all_but_last@163.com> writes:
>
>> @@ -1017,10 +1010,31 @@ from forcing GEXP-PROMISE."
>>             (lambda _
>>               (use-modules (guix build cargo-utils))
>>               (let ((null-hash "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"))
>> -               (substitute* '("Cargo.lock" "gfx/wr/Cargo.lock")
>> -                 (("(\"checksum .* = )\".*\"" all name)
>> -                  (string-append name "\"" null-hash "\"")))
>> -               (generate-all-checksums "third_party/rust"))
>> +               (for-each (lambda (file)
>> +                           (format #t "patching checksums in ~a~%" file)
>> +                           (substitute* (find-files "." "Cargo.lock$")
>> +                             (("^checksum = \".*\"")
>> +                              (string-append "checksum = \"" null-hash "\""))))
>> +                         (find-files "." "Cargo.lock$"))
>[...]
>> Why we need another `find-files` in `substitute*`? The outer
>> `find-files` should find all locks file for you, maybe you can use the
>> arg of lambda instead.
>
>Indeed, that's clearly what I had intended to do, but then I apparently
>forgot a step.  Good catch, thanks!
>
>> @@ -756,8 +750,8 @@ from forcing GEXP-PROMISE."
>>         ("libxt" ,libxt)
>>         ("libffi" ,libffi)
>>         ("ffmpeg" ,ffmpeg)
>> -       ("libvpx" ,libvpx)
>> -       ("icu4c" ,icu4c)
>> +       ;; UNBUNDLE-ME! ("libvpx" ,libvpx)
>> +       ;; UNBUNDLE-ME! ("icu4c" ,icu4c)
>>         ("pixman" ,pixman)
>>         ("pulseaudio" ,pulseaudio)
>>         ("mesa" ,mesa)
>>
>> IceCat 78 may need icu4c v67, which variable name is `icu4c-67` in
>> guix channel.
>
>Good idea!  Would you like to propose a patch, test it, and report back?
>If not, I'll try it eventually.  I would certainly be very glad to
>reduce the number of bundled libraries in our IceCat package, which
>seems to be getting worse over time.  Any help on that effort would be
>much appreciated.
>
>       Best,
>        Mark

[-- Attachment #2: Type: text/html, Size: 2820 bytes --]

      reply	other threads:[~2020-09-28  5:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-27 15:03 IceCat-78.2 preview on 'wip-icecat-78' branch; need icedove-78 Zhu Zihao
2020-09-27 20:15 ` Mark H Weaver
2020-09-28  5:23   ` Zhu Zihao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57eb9030.45b5.174d32a0d89.Coremail.all_but_last@163.com \
    --to=all_but_last@163.com \
    --cc=guix-devel@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.