all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: "Erik Šabič" <erik.sab@gmail.com>
Cc: 55675@debbugs.gnu.org
Subject: [bug#55675] [bug#55674] [PATCH 2/2] gnu: emacs-helpful: Update to 0.19.
Date: Fri, 27 May 2022 15:48:16 +0200	[thread overview]
Message-ID: <56da0d503f04884a5b3e407c36db50c75517b90e.camel@telenet.be> (raw)
In-Reply-To: <CABeAMAkLbQHB_aGAr_Tf8+1DPzjMSW1mKSUH6Zh7fPyZQCAeBg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1571 bytes --]

[Please keep 55675@debbugs.gnu.org in CC]

Erik Šabič schreef op vr 27-05-2022 om 15:32 [+0200]:
> Well it fails on a test defined like this:
> (ert-deftest helpful--docstring ()
>   "Basic docstring fetching."
>   (should
>    (equal
>     (helpful--docstring #'test-foo t)
>     "Docstring here.")))
> 
> And fails like so:
> ...............s...s..Test helpful--docstring-advice backtrace:


> 
> Test helpful--docstring-advice condition:
> 
>     (ert-test-failed
>      ((should
>        (equal
>         (helpful--docstring ... t)
>         "Docstring here too."))
>       :form
>       (equal "Docstring here too.\n\nThis function has :around
> advice: `ad-Advice-test-foo-advised'." "Docstring here too.")
>       :value nil :explanation
>       (arrays-of-different-length 84 19 "Docstring here too.\n\nThis
> function has :around advice: `ad-Advice-test-foo-advised'."
> "Docstring here too." first-mismatch-at 19)))
> 
> F............................................................s......

Looks like a bug.

> I don't know anything about emacs-ert. And I wasn't able to
> figure out if it works for the upstream author.
>
> WDYT?

I don't know if it fails for the upstream author, but I don't think
that's relevant to Guix.  More relevant I think, is that this bug
appears in Guix, so it can cause problems for Guix users, so some
fixing might be necessary.

I don't know much about Emacs though, so you might need to contact
upstream about the bug.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2022-05-27 13:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27 12:52 [bug#55675] [PATCH 1/2] gnu: emacs-elm-mode: Update to 0.21.0-1.1e27768 Erik Šabič
2022-05-27 12:52 ` [bug#55674] [PATCH 2/2] gnu: emacs-helpful: Update to 0.19 Erik Šabič
2022-05-27 13:12   ` Maxime Devos
     [not found]     ` <CABeAMAkLbQHB_aGAr_Tf8+1DPzjMSW1mKSUH6Zh7fPyZQCAeBg@mail.gmail.com>
2022-05-27 13:48       ` Maxime Devos [this message]
2022-05-27 17:23         ` Erik Šabič
2022-05-27 14:58   ` [bug#55674] Broken tests Erik Šabič
2022-05-29  5:05   ` [bug#55674] PR accepted yarl-baudig
2022-05-29  5:13   ` [bug#55674] [PATCH] gnu: emacs-helpful: Update to 209971b yarl-baudig
2022-05-29  7:41     ` Liliana Marie Prikler
2022-05-29  9:09       ` yarl-baudig
2022-05-29 10:12         ` Liliana Marie Prikler
2022-05-30  7:20           ` [bug#55674] [PATCH] gnu: emacs-helpful: Update to 0.19 yarl-baudig
2022-05-30 19:41             ` Liliana Marie Prikler
2022-05-30 21:11               ` yarl baudig
2022-06-04  7:00                 ` bug#55674: " Liliana Marie Prikler
2022-05-27 13:21 ` [bug#55675] Question Erik Šabič
2022-05-27 13:49   ` Maxime Devos
2022-05-27 14:27 ` [bug#55675] emacs-dash Erik Šabič
2022-06-05 21:34 ` bug#55675: [PATCH 1/2] gnu: emacs-elm-mode: Update to 0.21.0-1.1e27768 Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56da0d503f04884a5b3e407c36db50c75517b90e.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=55675@debbugs.gnu.org \
    --cc=erik.sab@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.