From: swedebugia <swedebugia@riseup.net>
To: guix-patches@gnu.org
Subject: bug#33673: PATCH: Fwd: Re: bug#33673: "guix system --help" does not detail how to use --on-error=strategy
Date: Fri, 14 Dec 2018 19:52:59 +0100 [thread overview]
Message-ID: <502fd617-38d4-c9e4-ad9c-ff237316d46e@riseup.net> (raw)
In-Reply-To: <87lg4wyopd.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]
Is this patch ok?
-------- Forwarded Message --------
Subject: Re: bug#33673: "guix system --help" does not detail how to use
--on-error=strategy
Date: Tue, 11 Dec 2018 18:10:06 +0100
From: Ludovic Courtès <ludo@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
CC: swedebugia@riseup.net, 33673@debbugs.gnu.org
Hi!
Efraim Flashner <efraim@flashner.co.il> skribis:
> On Sun, Dec 09, 2018 at 12:16:47AM +0100, Ludovic Courtès wrote:
[...]
>> Improvements are always welcome of course. The main criterion would be
>> to remain consistent with the rest of Guix and with GNU conventions that
>> we follow. Maybe it’s best to discuss what you have in mind first?
>>
>> Thank you,
>> Ludo’.
>>
>
> I'd go with (one of: nothing-special, backtrace, debug)
> with the assumption that for more information the manual is more
> verbose.
Sounds good to me. Would you like to send a patch?
> I also just noticed that we have 'man guix-system', which could be more
> verbose on the subject without needing to fit in a concise output.
Manual pages are generated from the ‘--help’ output, the canonical
documentation being the Info manual.
Thanks,
Ludo’.
[-- Attachment #2: 0001-system-Clarify-the-three-strategies-available.patch --]
[-- Type: text/x-patch, Size: 1747 bytes --]
From e71273a1b3b20bba8f4174ac4b98925bbc36ac0d Mon Sep 17 00:00:00 2001
From: swedebugia <swedebugia@riseup.net>
Date: Fri, 14 Dec 2018 19:41:41 +0100
Subject: [PATCH] system: Clarify the three strategies available.
* guix/scripts/system.scm (show-help): Clarify the three choices.
* doc/guix.texi (Invoking guix system): Add 3 @cindex to make on-error=strategy
easier to find.
---
doc/guix.texi | 3 +++
guix/scripts/system.scm | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index 20b5013fd..4c204c619 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -22628,6 +22628,9 @@ appear in the @code{operating-system} declaration actually exist
needed at boot time are listed in @code{initrd-modules} (@pxref{Initial
RAM Disk}). Passing this option skips these tests altogether.
+@cindex on-error
+@cindex on-error strategy
+@cindex error strategy
@item --on-error=@var{strategy}
Apply @var{strategy} when an error occurs when reading @var{file}.
@var{strategy} may be one of the following:
diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
index 8eb32c62b..d94917100 100644
--- a/guix/scripts/system.scm
+++ b/guix/scripts/system.scm
@@ -993,7 +993,7 @@ Some ACTIONS support additional ARGS.\n"))
instead of reading FILE, when applicable"))
(display (G_ "
--on-error=STRATEGY
- apply STRATEGY when an error occurs while reading FILE"))
+ apply STRATEGY (one of: nothing-special, backtrace, debug) when an error occurs while reading FILE."))
(display (G_ "
--file-system-type=TYPE
for 'disk-image', produce a root file system of TYPE
--
2.18.0
next prev parent reply other threads:[~2018-12-14 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-08 8:05 error: rmdir: Device or resource busy Fredrik Salomonsson
2018-12-08 8:24 ` swedebugia
2018-12-08 8:30 ` bug#33673: "guix system --help" does not detail how to use --on-error=strategy swedebugia
2018-12-08 23:16 ` Ludovic Courtès
2018-12-11 7:18 ` Efraim Flashner
2018-12-11 7:27 ` swedebugia
2018-12-11 17:10 ` Ludovic Courtès
2018-12-14 18:52 ` swedebugia [this message]
2018-12-18 10:54 ` bug#33673: PATCH: Fwd: " Ludovic Courtès
2018-12-09 4:31 ` error: rmdir: Device or resource busy Fredrik Salomonsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502fd617-38d4-c9e4-ad9c-ff237316d46e@riseup.net \
--to=swedebugia@riseup.net \
--cc=guix-patches@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.