From: Sarah Morgensen <iskarian@mgsn.dev>
To: 49917@debbugs.gnu.org
Subject: [bug#49917] [PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC 9+.
Date: Fri, 6 Aug 2021 14:40:17 -0700 [thread overview]
Message-ID: <5018c60ab22041bac940e7828fe197efcf8167e7.1628285642.git.iskarian@mgsn.dev> (raw)
With GCC 9+, go-1.14 fails a test when the gold linker is not
available (https://github.com/golang/go/issues/39157). Backport the fix
for that from https://github.com/golang/go/commit/4ec4a79.
gnu/packages/golang.scm (go-1.14)[arguments]<#:phases>{prebuild}:
Fix test failure with GCC 9+.
---
Hello Guix,
This fixes the CI failure at
https://ci.guix.gnu.org/build/725502/details
and probably for other platforms as well. This should also probably go to
core-updates.
--
Sarah
gnu/packages/golang.scm | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index d3ef39a2e6..cbcd9adb4c 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -1247,6 +1247,11 @@ in the style of communicating sequential processes (@dfn{CSP}).")
(("/bin/pwd") (which "pwd"))
(("/bin/sh") (which "sh")))
+ ;; Backport fix for go-1.14 with GCC 9+
+ ;; https://github.com/golang/go/issues/39157
+ (substitute* "cmd/go/note_test.go"
+ (("cannot find 'ld'") "cannot find [‘']ld[’']"))
+
;; Add libgcc to runpath
(substitute* "cmd/link/internal/ld/lib.go"
(("!rpath.set") "true"))
base-commit: b2a5a180cfa56e55bc8078d606a971e34e326967
--
2.31.1
next reply other threads:[~2021-08-06 21:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 21:40 Sarah Morgensen [this message]
2021-08-08 12:14 ` bug#49917: [PATCH core-updates-frozen] gnu: go-1.14: Fix test failure with GCC 9+ Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5018c60ab22041bac940e7828fe197efcf8167e7.1628285642.git.iskarian@mgsn.dev \
--to=iskarian@mgsn.dev \
--cc=49917@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.