all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>, 65668@debbugs.gnu.org
Cc: Raghav Gururajan <rg@raghavgururajan.name>
Subject: [bug#65668] [PATCH] gnu: gst-plugins-bad: Remove the svt-hevc input.
Date: Fri, 01 Sep 2023 06:21:42 +0200	[thread overview]
Message-ID: <4fa4754ecb68e0e9d7bc72c44229bcc404a5525a.camel@gmail.com> (raw)
In-Reply-To: <3e0b2b90b037404da7bf9be8932f9b0d69c1a39a.1693537692.git.maxim.cournoyer@gmail.com>

Am Donnerstag, dem 31.08.2023 um 23:08 -0400 schrieb Maxim Cournoyer:
> * gnu/packages/gstreamer.scm (gst-plugins-bad)
> [inputs]: Remove svt-hevc; add comment.
> ---
>  gnu/packages/gstreamer.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
> index 86886c025f..f38d2157bd 100644
> --- a/gnu/packages/gstreamer.scm
> +++ b/gnu/packages/gstreamer.scm
> @@ -849,7 +849,9 @@ (define-public gst-plugins-bad
>      (inputs
>       (append
>        (if (target-x86?) (list mediasdk) '())
> -      (if (target-x86-64?) (list svt-hevc) '())
> +      ;; Note: svt-hevc cannot be used, as it would break the
> package for
> +      ;; older x86_64 CPUs such as Core 2 Duo that lack AVX2 (see:
> +      ;;
> https://github.com/OpenVisualCloud/SVT-HEVC/issues/573#issuecomment-680678144
> ).
>        (list bluez
>              bzip2
>              cairo
I think you should put that comment above the commented existing line
rather than deleting it outright.  We should also look into building
svt-hevc without those CPU extensions; perhaps using tuning instead.

The comment could itself be shortened to 
  svt-hevc is broken on older x86_64 CPUs [such as…]
  see also <URL>
but you do you in terms of phrasing :)

Cheers




  reply	other threads:[~2023-09-01  4:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-01  3:08 [bug#65668] [PATCH] gnu: gst-plugins-bad: Remove the svt-hevc input Maxim Cournoyer
2023-09-01  4:21 ` Liliana Marie Prikler [this message]
2023-09-02  1:51   ` Maxim Cournoyer
2023-09-02  4:59     ` Liliana Marie Prikler
2023-09-03 14:49       ` Maxim Cournoyer
2023-09-06  3:47         ` bug#65668: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fa4754ecb68e0e9d7bc72c44229bcc404a5525a.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=65668@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.