all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
blob 4eea8ae5c56fc02055ff1ff47d7bb7a5b74b63d4 1183 bytes (raw)
name: gnu/packages/patches/go-github-com-prometheus-common-remove-readidletimeout.patch 	 # note: path name is non-authoritative(*)

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
 
ConfigureTransports was introduced in a newer version of
go-golang-org-x-net:
<https://github.com/golang/net/commit/08b38378de702b893ee869b94b32f833e2933bd2>

Prior to this, Prometheus didn't configure ReadIdleTimeout:
<https://github.com/prometheus/common/commit/b5c358997cbf126e8f8518cdc024c32da3996d48>

It's somewhat unclear whether ReadIdleTimeout is absolutely required to
work around the upstream issues with HTTP/2 mentioned in the codebase,
however HTTP/2 can be disabled using enable_http2 if this is the case.

diff --git a/config/http_config.go b/config/http_config.go
index 4b87241..7698ba4 100644
--- a/config/http_config.go
+++ b/config/http_config.go
@@ -411,11 +411,10 @@ func NewRoundTripperFromConfig(cfg HTTPClientConfig, name string, optFuncs ...HT
 			// issues again, but will be removed once we are confident that
 			// things work as expected.
 
-			http2t, err := http2.ConfigureTransports(rt.(*http.Transport))
+			err := http2.ConfigureTransport(rt.(*http.Transport))
 			if err != nil {
 				return nil, err
 			}
-			http2t.ReadIdleTimeout = time.Minute
 		}
 
 		// If a authorization_credentials is provided, create a round tripper that will set the

debug log:

solving 4eea8ae5c5 ...
found 4eea8ae5c5 in https://yhetil.org/guix/20220325133211.5128-4-hello@lnikki.la/

applying [1/1] https://yhetil.org/guix/20220325133211.5128-4-hello@lnikki.la/
diff --git a/gnu/packages/patches/go-github-com-prometheus-common-remove-readidletimeout.patch b/gnu/packages/patches/go-github-com-prometheus-common-remove-readidletimeout.patch
new file mode 100644
index 0000000000..4eea8ae5c5

1:23: space before tab in indent.
 			// issues again, but will be removed once we are confident that
1:24: space before tab in indent.
 			// things work as expected.
1:25: trailing whitespace.
 
1:28: space before tab in indent.
 			if err != nil {
1:29: space before tab in indent.
 				return nil, err
Checking patch gnu/packages/patches/go-github-com-prometheus-common-remove-readidletimeout.patch...
Applied patch gnu/packages/patches/go-github-com-prometheus-common-remove-readidletimeout.patch cleanly.
warning: squelched 4 whitespace errors
warning: 9 lines add whitespace errors.

index at:
100644 4eea8ae5c56fc02055ff1ff47d7bb7a5b74b63d4	gnu/packages/patches/go-github-com-prometheus-common-remove-readidletimeout.patch

(*) Git path names are given by the tree(s) the blob belongs to.
    Blobs themselves have no identifier aside from the hash of its contents.^

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.