From: Maxime Devos <maximedevos@telenet.be>
To: zimoun <zimon.toutoune@gmail.com>, pinoaffe <pinoaffe@airmail.cc>
Cc: 50755@debbugs.gnu.org
Subject: [bug#50755] [PATCH v3] import: Generate list of importers based on available modules
Date: Tue, 28 Sep 2021 11:51:48 +0200 [thread overview]
Message-ID: <4ddbb2adfa86c9ed2e1cf01ad5c1d0129553cbae.camel@telenet.be> (raw)
In-Reply-To: <CAJ3okZ05LLzBLTY_srqarf1LG-tq2sN7wJmg3UaU7fxFBMovHQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1337 bytes --]
zimoun schreef op ma 27-09-2021 om 22:09 [+0200]:
> Hi,
>
> On Mon, 27 Sept 2021 at 20:21, pinoaffe <pinoaffe@airmail.cc> wrote:
>
> > +(define importers (delete-duplicates
>
> This fixes my first point...
>
> > + (filter-map (lambda (module)
> > + (match (module-name module)
> > + (`(guix scripts import ,importer)
> > + (symbol->string importer))
> > + ( #t #f)))
> > + (all-modules (map (lambda (entry)
> > + `(,entry . "guix/scripts/import"))
> > + %load-path)))))
>
> ...and it means it is walking more than needed. Therefore, what is
> the performance loss?
>
> For instance, on my machine and hot cache, it is 4x slower.
FWIW, calling ./pre-inst-env guix ... will always be slower than guix ...,
because the former will have a longer %load-path (IIRC) and possibly
other reasons.
Using "guix pull --profile=..." "time .../guix import ..." might be a better test.
To only measure the time required for defiing 'importers', wrap delete-duplicates
in a call to 'time' from (ice-9 time).
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-09-28 9:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 12:24 [bug#50755] [PATCH] import: Generate list of importers based on available modules pinoaffe
2021-09-23 18:07 ` Sarah Morgensen
2021-09-23 21:17 ` pinoaffe
2021-09-23 21:19 ` [bug#50755] [PATCH v2] " pinoaffe
2021-09-27 14:28 ` zimoun
2021-09-27 18:27 ` pinoaffe
2021-09-27 18:20 ` [bug#50755] [PATCH v3] " pinoaffe
2021-09-27 20:09 ` zimoun
2021-09-28 9:51 ` Maxime Devos [this message]
2021-09-28 14:39 ` pinoaffe
2021-09-29 20:59 ` Maxime Devos
2021-09-30 8:17 ` pinoaffe
2021-09-30 8:37 ` Maxime Devos
2021-10-11 11:51 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ddbb2adfa86c9ed2e1cf01ad5c1d0129553cbae.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=50755@debbugs.gnu.org \
--cc=pinoaffe@airmail.cc \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.