all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kaelyn <kaelyn.alexi@protonmail.com>
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: Fix for librsvg 2.40 on core-updates
Date: Sat, 08 Apr 2023 15:55:03 +0000	[thread overview]
Message-ID: <4d68e4l1D7epKiEbdZefULMDUj6WUrxFmgrCghEBvl8fe6nggOmIuGdZy3-_63OUeePRvJLKQtn2Jug2Mh-K4Rx0i3aVixEvjVMGH0h4ceU=@protonmail.com> (raw)
In-Reply-To: <ZDE5XTWVO7lJshkJ@jurong>

------- Original Message -------
On Saturday, April 8th, 2023 at 9:52 AM, Andreas Enge <andreas@enge.fr> wrote:


> 
> 
> Hello,
> 
> Am Fri, Apr 07, 2023 at 04:53:15PM +0000 schrieb Kaelyn:
> 
> > On core-updates, librsvg-2.40 fails to compile due to a single failing test (I've confirmed the failure on x86_64 and i686, though the package is only used/needed on non-x86_64 systems for gtk+ and others; it also affects wine and wine-staging on x86_64 as they are 32-bit packages). I was able to track down the test failure to a text rendering difference between Pango 1.48 and 1.50, which led to the text being one pixel line higher between the reference and output images. On Monday I submitted https://issues.guix.gnu.org/62646 which adds a phase to librsvg-2.40 to adjust the output Y coordinate of the SVG transformation matrix by one for the failing test so that it passes with Pango 1.50.
> 
> 
> thanks a lot, I added a copyright line for you and pushed.

Thank you! (I often forget the copyright line, so thanks for that as well.)

> 
> Wine still fails to build due to autogen not building on i686:
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../autoopts -DPKGDATADIR=\"/gnu/store/6i60j0fxdsg4qwymas4ymfqlv1azidnc-autogen-5.18.16/share/autogen\" -g -O2 -Wno-format-contains-nul -fno-strict-aliasing -Wall -Werror -Wcast-align -Wmissing-prototypes -Wpointer-arith -Wshadow -Wstrict-prototypes -Wwrite-strings -Wstrict-aliasing=3 -Wextra -Wno-cast-qual -g -O2 -Wno-format-contains-nul -fno-strict-aliasing -c libopts.c -fPIC -DPIC -o .libs/libopts_la-libopts.o
> In file included from libopts.c:48:
> usage.c: In function ‘prt_extd_usage.isra’:
> usage.c:736:38: error: ‘s ’ directive output may be truncated writing 2 bytes into a region of size between 0 and 9 [-Werror=format-truncation=]
> 736 | snprintf(vfmt, sizeof(vfmt), vfmtfmt, (unsigned int)nmlen + 4);
> | ^~~~~~~
> usage.c:736:9: note: ‘snprintf’ output between 9 and 18 bytes into a destination of size 12
> 736 | snprintf(vfmt, sizeof(vfmt), vfmtfmt, (unsigned int)nmlen + 4);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Just in case you wish to continue investigating :)

I probably will. :) My goal has been to build my home and system profiles from core-updates, including wine64-staging.

Cheers,
Kaelyn

> 
> Andreas


  reply	other threads:[~2023-04-08 15:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-07 16:53 Fix for librsvg 2.40 on core-updates Kaelyn
2023-04-08  9:52 ` Andreas Enge
2023-04-08 15:55   ` Kaelyn [this message]
2023-04-10 19:00     ` Kaelyn
2023-04-10 19:29       ` Felix Lechner via Development of GNU Guix and the GNU System distribution.
2023-04-11 11:58       ` bug#62723: " Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='4d68e4l1D7epKiEbdZefULMDUj6WUrxFmgrCghEBvl8fe6nggOmIuGdZy3-_63OUeePRvJLKQtn2Jug2Mh-K4Rx0i3aVixEvjVMGH0h4ceU=@protonmail.com' \
    --to=kaelyn.alexi@protonmail.com \
    --cc=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.