all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: phodina via Guix-patches via <guix-patches@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 53169@debbugs.gnu.org, 53169-done@debbugs.gnu.org
Subject: [bug#53169] [PATCH 1/8] gnu: Add rust-svgtypes-0.5.
Date: Fri, 21 Jan 2022 05:08:21 +0000	[thread overview]
Message-ID: <4W_OFIVSghgKzGdPYCJWGgbflwSWAfghBO68JmGraHzMjbrVJMLkNY2OcRVeNevkAV5E-NiVDruBNf7Kre8Cpkx9J1LkWRoy6gYsue8aN-E=@protonmail.com> (raw)
In-Reply-To: <87fspi7xbk.fsf@nicolasgoaziou.fr>

Hi Nicolas,

> Note that some of your commit messages were misleading. E.g., when you
>
> write "gnu: rust-euclid-0.22: Update to 0.22.6.", you actually create
>
> a new variable `rust-euclid-0.22' and remove` rust-euclid-0.20'. As
>
> a consequence it broke old revisions of `plotters' and` font-kit'
>
> crates, which I had to remove.
>
> Also, indentation from imported packages is a bit off. You may want to
>
> re-indent packages.
>
> In any case, all applied!

Thanks for the note. You're right that in case "gnu: rust-euclid-0.22" it's new variable as there are dependencies on the old one.

I'll keep that in mind next time :-)


----
Petr




      reply	other threads:[~2022-01-21  5:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11  0:31 [bug#53169] [PATCH 1/8] gnu: Add rust-svgtypes-0.5 phodina via Guix-patches via
2022-01-21  0:21 ` Nicolas Goaziou
2022-01-21  5:08   ` phodina via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='4W_OFIVSghgKzGdPYCJWGgbflwSWAfghBO68JmGraHzMjbrVJMLkNY2OcRVeNevkAV5E-NiVDruBNf7Kre8Cpkx9J1LkWRoy6gYsue8aN-E=@protonmail.com' \
    --to=guix-patches@gnu.org \
    --cc=53169-done@debbugs.gnu.org \
    --cc=53169@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --cc=phodina@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.