all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 51845@debbugs.gnu.org
Subject: [bug#51845] [PATCH 0/2] Add librsvg-bootstrap
Date: Sun, 14 Nov 2021 20:05:30 +0100	[thread overview]
Message-ID: <49868b918eb291fd2761c48c7617fecd6bb98764.camel@gmail.com> (raw)
In-Reply-To: <YZFQRR5PDcnazL04@3900XT>

Hi,

Am Sonntag, den 14.11.2021, 20:07 +0200 schrieb Efraim Flashner:
> > As a temporary resolution to the rebuild issue, we could pin the
> > dependencies of librsvg to some specific versions and only bump 
> > them something awful happens.  I'm not sure whether librsvg
> > exposes any of the Rust nastiness to its dependencies, ideally
> > hoping that it would not.
> 
> I don't believe librsvg exposes any rust-y stuff.
That sounds like a good start for once.

> > WDYT?
> 
> (ins)efraim@3900XT /tmp/librsvg-2.50.7$ ls vendor/ | wc -l
> 226
> 
> There are 226 crates that upstream bundles with their source. I
> suppose we could pare it down to about 200 by careful pruning but
> it's part of librsvg and not going away.
Well, I'd suggest snippeting them away, but that's a different topic.

> (ins)efraim@3900XT ~/workspace/guix-core-updates$ git grep \,librsvg
> | wc -l
> 103
I'd hazard a guess that most if not all of these 103 packages are
themselves gtk-adjacent, so what really is the issue we're solving
here?  What is the point of maintaining an extra version for 101 of
them when a potentially vulnerable GTK sits right next to them?

> I'm suggesting that for gtk+@2 and gtk+@3 we use the bundled crates
> and for the other 101 packages we continue to use our current
> version, where we replace all of the bundled crates with our own
> copies, which get updated more often than librsvg does.
> 
> With our current rust tooling I don't think it'd be that easy to find
> the ~226 crates that librsvg depends on, and it wouldn't be great to
> lock them due to librsvg being an input for gtk2/3.
Said input exists due to gdk-pixbuf+svg, with the +svg part being
largely optional – the most common failure mode of it not being
included are broken button textures, which we could fix by pre-
rendering images with a suitable tool, such as inkscape.  We could
easily do a minimal gtk[+]? without it.

As for the lock, why can't we?  gtk+ is already core-updates material,
so it stands to reason that anything causing it to rebuild is too. 
Rather than push down blobs to the users because we can't deal with
Rust, we should fix Rust or make it go away from the build.

WDYT?





  reply	other threads:[~2021-11-14 19:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-14 14:07 [bug#51845] [PATCH 0/2] Add librsvg-bootstrap Efraim Flashner
2021-11-14 14:14 ` [bug#51845] [PATCH 1/2] gnu: " Efraim Flashner
2021-11-14 14:14 ` [bug#51845] [PATCH 2/2] gnu: Use librsvg-bootstrap Efraim Flashner
2021-11-14 17:27 ` [bug#51845] [PATCH 0/2] Add librsvg-bootstrap Liliana Marie Prikler
2021-11-14 18:07   ` Efraim Flashner
2021-11-14 19:05     ` Liliana Marie Prikler [this message]
2021-12-06 12:17 ` Ludovic Courtès
2021-12-06 13:06   ` Efraim Flashner
2021-12-06 16:37     ` Ludovic Courtès
2021-12-06 17:02       ` Efraim Flashner
2021-12-06 22:17         ` [bug#51845] Using ‘native-inputs’ and ‘inputs’ for Cargo packages? Ludovic Courtès
2021-12-07 10:11           ` Efraim Flashner
2021-12-07 19:48             ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49868b918eb291fd2761c48c7617fecd6bb98764.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=51845@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.