all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zamfofex <zamfofex@twdb.moe>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>, 68987@debbugs.gnu.org
Cc: 宋文武 <iyzsong@envs.net>
Subject: [bug#68987] [PATCH 1/2] gnu: moonfish: Update to 0-2.2118580.
Date: Thu, 8 Feb 2024 20:34:41 -0300 (BRT)	[thread overview]
Message-ID: <446771014.2091784.1707435281696@privateemail.com> (raw)
In-Reply-To: <efce36d9ba2954914522d43aa6efddef14619c5a.camel@gmail.com>

> Please don't mix in cosmetic changes with semantic ones.  IMHO the
> indentation is fine as-is.

Sure. I just ran ‘guix style’ on it before committing, I thought it would have been warranted. I can undo the changes it made, sure.

> […]
> You forgot to document this change…
> […]
> … as well as this.

Sure, I’ll do that and send a new patch soon! Thanks for reviewing.




  reply	other threads:[~2024-02-08 23:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08  0:31 [bug#68987] [PATCH 0/2] update moonfish zamfofex
2024-02-08  0:34 ` [bug#68987] [PATCH 1/2] gnu: moonfish: Update to 0-2.2118580 zamfofex
2024-02-08 17:50   ` Liliana Marie Prikler
2024-02-08 23:34     ` zamfofex [this message]
2024-02-08  0:34 ` [bug#68987] [PATCH 2/2] gnu: moonfish: Improve description zamfofex
2024-02-28 10:30 ` [bug#68987] Ping Andreas Enge
2024-03-25 13:55 ` [bug#68987] [PATCH v2 1/2] gnu: moonfish: Update to 0-2.fd3471d zamfofex
2024-03-25 13:55   ` [bug#68987] [PATCH v2 2/2] gnu: moonfish: Improve description zamfofex
2024-03-26 20:01 ` [bug#68987] [PATCH v3 1/2] gnu: moonfish: Update to 0-2.fb2cb4f zamfofex
2024-03-26 20:01   ` [bug#68987] [PATCH v3 2/2] gnu: moonfish: Improve description zamfofex
2024-03-27 12:57     ` bug#68987: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=446771014.2091784.1707435281696@privateemail.com \
    --to=zamfofex@twdb.moe \
    --cc=68987@debbugs.gnu.org \
    --cc=iyzsong@envs.net \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.