From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: jgart <jgart@dismail.de>, 61724@debbugs.gnu.org
Cc: control@debbugs.gnu.org
Subject: [bug#61724] [PATCH 1/3] gnu: Add nlohmann-json.
Date: Thu, 23 Feb 2023 18:57:14 +0100 [thread overview]
Message-ID: <3fe4ac9696ec9c962e4a120ca1292ab4fc0e7b70.camel@gmail.com> (raw)
In-Reply-To: <20230223051201.17541-1-jgart@dismail.de>
merge 61672 61724
thanks
Hi jgart,
Am Donnerstag, dem 23.02.2023 um 06:11 +0100 schrieb jgart:
> * gnu/packages/cpp.scm (nlohmann-json): New variable.
> ---
> gnu/packages/cpp.scm | 98 +++++++++++++++++-------------------------
> --
> 1 file changed, 37 insertions(+), 61 deletions(-)
>
> diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> index ed6ae69198..7091459d97 100644
> --- a/gnu/packages/cpp.scm
> +++ b/gnu/packages/cpp.scm
> @@ -22,7 +22,7 @@
> ;;; Copyright © 2021 Nicolò Balzarotti <nicolo@nixo.xyz>
> ;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
> ;;; Copyright © 2021 Nikolay Korotkiy <sikmir@disroot.org>
> -;;; Copyright © 2021 jgart <jgart@dismail.de>
> +;;; Copyright © 2021, 2023 jgart <jgart@dismail.de>
> ;;; Copyright © 2021 Julien Lepiller <julien@lepiller.eu>
> ;;; Copyright © 2021 Disseminate Dissent
> <disseminatedissent@protonmail.com>
> ;;; Copyright © 2022 Efraim Flashner <efraim@flashner.co.il>
> @@ -595,74 +595,50 @@ (define-public json-dto
> data transfer object.")
> (license license:bsd-3)))
>
> -(define-public json-modern-cxx
> +(define-public nlohmann-json
> (package
> - (name "json-modern-cxx")
> - (version "3.10.5")
> - (home-page "https://github.com/nlohmann/json")
> + (name "nlohmann-json")
> + (version "3.11.2")
Perform one logical change at a time:
1. Updating is a logical change.
2. Renaming and adjusting dependant packages is a logical change.
When adding a deprecated alias, it should be done in the same commit as
the rename (2).
The order of commits between (1) and (2) doesn't matter.
Cheers
next prev parent reply other threads:[~2023-02-23 17:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 5:06 [bug#61724] [PATCH 1/3] gnu: Add nlohmann-json jgart via Guix-patches via
2023-02-23 5:11 ` jgart via Guix-patches via
2023-02-23 5:12 ` [bug#61724] [PATCH 2/3] gnu: json-modern-cxx: Remove deprecated package jgart via Guix-patches via
2023-02-23 5:12 ` [bug#61724] [PATCH 3/3] gnu: Refactor packages to use new nlohmann-json variable jgart via Guix-patches via
2023-02-23 17:57 ` Liliana Marie Prikler [this message]
2023-02-23 20:17 ` [bug#61724] [PATCH v2 1/2] gnu: Add nlohmann-json jgart via Guix-patches via
2023-02-23 20:17 ` [bug#61724] [PATCH v2 2/2] gnu: Refactor packages to use new nlohmann-json variable jgart via Guix-patches via
2023-02-23 20:59 ` [bug#61724] [PATCH v2 1/2] gnu: Add nlohmann-json Liliana Marie Prikler
2023-03-10 1:58 ` jgart via Guix-patches via
2023-03-10 5:18 ` Liliana Marie Prikler
2023-04-27 18:57 ` [bug#61724] [PATCH v3 1/3] gnu: Rename json-modern-cxx to nlohmann-json Liliana Marie Prikler
2023-04-27 18:57 ` [bug#61724] [PATCH v4 1/7] " Liliana Marie Prikler
2023-04-28 19:50 ` [bug#61724] [PATCH v4 2/7] gnu: nlohmann-json: Update to 3.11.2 Liliana Marie Prikler
2023-04-28 19:55 ` [bug#61724] [PATCH v4 3/7] gnu: nlohmann-json: Improve package style Liliana Marie Prikler
2023-05-07 16:50 ` [bug#61724] [PATCH v4 3/3] gnu: nlohmann-json: Improve package style. (was [PATCH v4 3/7] gnu: nlohmann-json: Improve package style.) Liliana Marie Prikler
2023-05-11 12:53 ` [bug#61724] [PATCH v4 1/7] gnu: Rename json-modern-cxx to nlohmann-json Simon Tournier
2023-05-11 18:48 ` Liliana Marie Prikler
2023-05-14 10:24 ` bug#61724: " Liliana Marie Prikler
2023-04-28 19:50 ` [bug#61724] [PATCH v3 2/3] gnu: nlohmann-json: Update to 3.11.2 Liliana Marie Prikler
2023-04-29 0:15 ` jgart via Guix-patches via
2023-04-28 19:55 ` [bug#61724] [PATCH v3 3/3] gnu: nlohmann-json: Improve package style Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fe4ac9696ec9c962e4a120ca1292ab4fc0e7b70.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=61724@debbugs.gnu.org \
--cc=control@debbugs.gnu.org \
--cc=jgart@dismail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.