all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: "Simon Tournier" <zimon.toutoune@gmail.com>,
	"Ludovic Courtès" <ludo@gnu.org>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: $EDITOR and “guix edit”
Date: Fri, 12 Jan 2024 18:39:07 +0100	[thread overview]
Message-ID: <37da112158ce2ecd4505742c573af37e74c271cf.camel@gmail.com> (raw)
In-Reply-To: <87r0imyjvp.fsf@gmail.com>

Am Freitag, dem 12.01.2024 um 10:35 +0100 schrieb Simon Tournier:
> Hi,
> 
> On Mon, 20 Nov 2023 at 20:33, Liliana Marie Prikler
> <liliana.prikler@gmail.com> wrote:
> 
> > >  2. Do we put this code in some etc/vscode-wrapper that user can
> > >  install?  (or that we could automatically installl) Or maybe
> > > revamp it for calling this code via some shell function?
> > 
> > With VSCode et al. not being Guix packages, I see little point in
> > providing these wrappers through Guix itself.
> 
> I do not want to address here where to keep VSCode support and
> instead I would like to address $EDITOR which does not follow the
> good ol’ fashion.
> 
> Well, I see how to write specific Scheme wrapper around $EDITOR; as I
> did in [1].
> 
> Or, I see how to tweak guix/scripts/edit.scm for running specific
> launcher depending on $EDITOR.
> 
> Liliana, could you provide a proof-of-concept about « the shell-esque
> "${LINE}" and "${FILE}" that would get replaced by Scheme code
> looking for those strings »?  Because I do not see what you mean.
(let* ((editor (getenv "GUIX_EDITOR"))
       (editor (string-replace-substring editor "${FILE}" the-file))
       (editor (string-replace-substring editor "${LINE}" the-line)))
  editor)
with the-file and the-line being placeholders for the actual variable
names.  You could obviously do smarter things with gash, but let's not
go there at the moment.

> Cheers,
> simon
> 
> 1:
> https://gitlab.com/zimoun/advanced-packages-2023/-/blob/main/vscode-wrapper?ref_type=heads
> 
> PS:
> 
> About VSCode.  Somehow, it is a chicken-or-the-eggs problem.  “We“
> cannot complain with lengthy threads about the lack of contributor
> diversity, or that many Guix tools are Emacs-centric, etc. and in the
> same time say no because VSCode is not packaged in Guix proper.
> 
> We like it or not – I do not like it and do not use it! – for sure,
> VSCode is currently one of the most used editor around.  Being
> friendly with VSCode users would help to have more contributions from
> them.
Speaking of diversity, how well does your wrapper work for Atom?  Or
Kate?  IMHO, going out of our way to specifically support VSCode would
break not one, but at least two of our core principles, whereas
offering an option that you can plug any $EDITOR into would not only be
the technically, but also morally superior choice.
 
Cheers


  reply	other threads:[~2024-01-12 17:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02  9:43 $EDITOR and “guix edit” Simon Tournier
2023-11-02 10:24 ` Liliana Marie Prikler
2023-11-16 15:25   ` Ludovic Courtès
2023-11-16 16:04     ` Liliana Marie Prikler
2023-11-20  9:40       ` Simon Tournier
2023-11-20 19:33         ` Liliana Marie Prikler
2024-01-12  9:35           ` Simon Tournier
2024-01-12 17:39             ` Liliana Marie Prikler [this message]
2024-01-12 18:49               ` Simon Tournier
2024-01-12 19:46                 ` Liliana Marie Prikler
2024-01-12 21:27                   ` Simon Tournier
2023-11-22 18:21       ` Ludovic Courtès
2023-11-22 19:24         ` Liliana Marie Prikler
2023-12-09  9:24           ` Ludovic Courtès
2023-12-09  9:55             ` Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37da112158ce2ecd4505742c573af37e74c271cf.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.