From: Maxime Devos <maximedevos@telenet.be>
To: Brian Cully <bjc@spork.org>, 55369@debbugs.gnu.org
Cc: Brian Cully <bjc@kublai.com>
Subject: [bug#55369] [PATCH 1/2] gnu: zfs: Use new package style.
Date: Wed, 11 May 2022 16:57:53 +0200 [thread overview]
Message-ID: <2cbe4ede93a89125eab0b2836170ba6c0a8f6ee4.camel@telenet.be> (raw)
In-Reply-To: <9c79808be27869958987782313cec824787b651f.1652276252.git.bjc@spork.org>
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
Brian Cully via Guix-patches via schreef op wo 11-05-2022 om 09:37 [-
0400]:
> - (add-after 'unpack 'patch-source
> - (lambda* (#:key inputs outputs #:allow-other-keys)
> - (let ((out (assoc-ref outputs "out"))
> - (src (assoc-ref outputs "src"))
> - (util-linux (assoc-ref inputs "util-linux"))
> - (nfs-utils (assoc-ref inputs "nfs-utils"))
> - (kmod (assoc-ref inputs "kmod-runtime")))
[...]
> + (add-after 'unpack 'patch-source
> + (lambda _ [...]
> + (substitute* "lib/libzfs/os/linux/libzfs_util_os.c"
> + ;; Use path to /gnu/store/*-kmod in actual path that is exec'ed.
> + (("\"/sbin/modprobe\"")
> + (string-append "\"" #$kmod "/bin/modprobe" "\""))
This breaks package transformations -- now the 'kmod' from (gnu
packages linux) is hardcoded, it cannot be replaced by something else
with --with-input or (package (inherit ...) (inputs (list custom-kmod
...)) or the like. (Currently no mechanism exists to rewrite G-exps.)
Instead, do
(lambda* (#:key inputs #:allow-other-keys)
[...]
(string-append "\"" (search-input-file inputs "bin/modprobe))
[...])
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-05-11 14:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 13:37 [bug#55369] [PATCH 1/2] gnu: zfs: Use new package style Brian Cully via Guix-patches via
2022-05-11 13:40 ` [bug#55369] [PATCH] gnu: Change OpenZFS home page to reflect new project ownership Brian Cully via Guix-patches via
2022-05-11 14:53 ` [bug#55369] [PATCH 1/2] gnu: zfs: Use new package style Maxime Devos
2022-05-11 14:57 ` Maxime Devos [this message]
2022-05-11 15:43 ` [bug#55369] [PATCH v2 " Brian Cully via Guix-patches via
2022-05-11 19:33 ` Maxime Devos
2022-05-11 15:48 ` [bug#55369] [PATCH v2] gnu: Change OpenZFS home page to reflect new project ownership Brian Cully via Guix-patches via
2022-05-11 19:36 ` Maxime Devos
2022-05-12 3:05 ` Brian Cully via Guix-patches via
2022-05-12 14:36 ` Brian Cully via Guix-patches via
2022-05-12 14:43 ` Maxime Devos
2022-05-12 15:07 ` Brian Cully via Guix-patches via
2022-05-12 15:05 ` [bug#55369] [PATCH v3 1/2] gnu: zfs: Use new package style Brian Cully via Guix-patches via
2022-05-20 18:15 ` bug#55369: [PATCH " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cbe4ede93a89125eab0b2836170ba6c0a8f6ee4.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=55369@debbugs.gnu.org \
--cc=bjc@kublai.com \
--cc=bjc@spork.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.