all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Greg Hogan <code@greghogan.com>
To: 63453@debbugs.gnu.org
Cc: Greg Hogan <code@greghogan.com>
Subject: [bug#63453] [PATCH v2 1/3] gnu: python-docrepr: Fix tests.
Date: Mon, 22 May 2023 20:17:39 +0000	[thread overview]
Message-ID: <2a767f5253f02d05d29a0c3107d5a8c4bd28724b.1684785831.git.code@greghogan.com> (raw)
In-Reply-To: <cover.1684785831.git.code@greghogan.com>

* gnu/packages/patches/python-docrepr-fix-tests.patch: New file.
* gnu/local.mk (dist_patch_DATA): Register it here.
* gnu/packages/documentation.scm (python-docrepr)[source]<patches>: Use
  it here.
---
 gnu/local.mk                                     |  1 +
 gnu/packages/documentation.scm                   |  3 ++-
 .../patches/python-docrepr-fix-tests.patch       | 16 ++++++++++++++++
 3 files changed, 19 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/python-docrepr-fix-tests.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index c10fb01bb3..b5d43d7203 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1682,6 +1682,7 @@ dist_patch_DATA =						\
   %D%/packages/patches/prusa-slicer-with-cereal-1.3.1.patch	\
   %D%/packages/patches/pthreadpool-system-libraries.patch	\
   %D%/packages/patches/python-chai-drop-python2.patch		\
+  %D%/packages/patches/python-docrepr-fix-tests.patch		\
   %D%/packages/patches/python-feedparser-missing-import.patch	\
   %D%/packages/patches/python-louvain-fix-test.patch		\
   %D%/packages/patches/python-random2-getrandbits-test.patch		\
diff --git a/gnu/packages/documentation.scm b/gnu/packages/documentation.scm
index bbaa01e392..be64bc4f95 100644
--- a/gnu/packages/documentation.scm
+++ b/gnu/packages/documentation.scm
@@ -296,7 +296,8 @@ (define-public python-docrepr
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1ma5gwy93m1djd3zdlnqfrwhgr8ic1qbsz5kkrb9f987ax40lfkd"))))
+                "1ma5gwy93m1djd3zdlnqfrwhgr8ic1qbsz5kkrb9f987ax40lfkd"))
+              (patches (search-patches "python-docrepr-fix-tests.patch"))))
     (build-system python-build-system)
     (arguments
      (list
diff --git a/gnu/packages/patches/python-docrepr-fix-tests.patch b/gnu/packages/patches/python-docrepr-fix-tests.patch
new file mode 100644
index 0000000000..a209921025
--- /dev/null
+++ b/gnu/packages/patches/python-docrepr-fix-tests.patch
@@ -0,0 +1,16 @@
+Fixes the errors with use of asyncio in docrepr/tests/test_output.py:
+     
+>       await compare_screenshots(test_id, url)
+E       TypeError: 'coroutine' object is not callable
+
+--- a/conftest.py
++++ b/conftest.py
+@@ -65,7 +65,7 @@ def _open_browser(url):
+ 
+ 
+ @pytest.fixture
+-async def compare_screenshots(request):
++def compare_screenshots(request):
+     """Run visual regression test on the output."""
+     async def _compare_screenshots(test_id, url):
+         if (request.config.getoption(COMPARE_SCREENSHOTS_OPTION) or
-- 
2.40.1





  reply	other threads:[~2023-05-22 20:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-11 20:36 [bug#63453] [PATCH] gnu: python-ipython-documentation: Remove patches Greg Hogan
2023-05-22 14:49 ` Ludovic Courtès
2023-05-22 19:37   ` Greg Hogan
2023-05-22 20:17 ` [bug#63453] [PATCH v2 0/3] Fix build for python-ipython-documentation Greg Hogan
2023-05-22 20:17   ` Greg Hogan [this message]
2023-05-22 20:17   ` [bug#63453] [PATCH v2 2/3] gnu: python-ipython-documentation: Remove patches Greg Hogan
2023-05-22 20:17   ` [bug#63453] [PATCH v2 3/3] gnu: python-ipython-documentation: Update dependencies Greg Hogan
2023-06-02 14:14   ` bug#63453: [PATCH] gnu: python-ipython-documentation: Remove patches Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a767f5253f02d05d29a0c3107d5a8c4bd28724b.1684785831.git.code@greghogan.com \
    --to=code@greghogan.com \
    --cc=63453@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.