From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Vivien Kraus <vivien@planete-kraus.eu>, 69652@debbugs.gnu.org
Cc: rg@raghavgururajan.name, maxim.cournoyer@gmail.com
Subject: [bug#69652] [PATCH gnome-team 1/1] gnu: orbit2: Mark it unsupported in 32-bits systems.
Date: Fri, 08 Mar 2024 20:11:06 +0100 [thread overview]
Message-ID: <21fccba3ffea43414af7d8d441e03689ad41474b.camel@gmail.com> (raw)
In-Reply-To: <f4d66a6dd79c865b94a50523f6c4464399e13389.1709918975.git.vivien@planete-kraus.eu>
Am Freitag, dem 08.03.2024 um 18:20 +0100 schrieb Vivien Kraus:
> * gnu/packages/gnome.scm (orbit2) [supported-systems]: New field.
> [arguments]: Convert to list of G-Expressions.
>
> Change-Id: I55766c43e7abc703815c30dccf38faf640ffc07e
> ---
> gnu/packages/gnome.scm | 53 ++++++++++++++++++++++------------------
> --
> 1 file changed, 28 insertions(+), 25 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 13cad0add2..711890d617 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -3798,34 +3798,37 @@ (define-public orbit2
> (sha256
> (base32
>
> "0l3mhpyym9m5iz09fz0rgiqxl2ym6kpkwpsp1xrr4aa80nlh1jam"))))
> + ;; Many tests fail on 32-bit systems.
> + (supported-systems %64bit-supported-systems)
Prefer the “disable-failing-tests” pattern, but first investigate why
they fail. Note that this would make icecat and icedove 64-bit only
(that is if Rust doesn't do so already).
> (build-system gnu-build-system)
> (arguments
> - `(;; The "timeout-server" test hangs when run in parallel.
> - #:parallel-tests? #f
> - #:configure-flags
> - '(;; We don't need static libraries, plus they don't build
> reproducibly
> - ;; (non-deterministic ordering of .o files in the archive.)
> - "--disable-static"
> -
> - ;; The programmer kindly gives us a hook to turn off
> deprecation
> - ;; warnings ...
> - "DISABLE_DEPRECATED_CFLAGS=-
> DGLIB_DISABLE_DEPRECATION_WARNINGS")
> - ;; ... which they then completly ignore !!
> - #:phases
> - (modify-phases %standard-phases
> - (add-after 'unpack 'fix-parallel-build
> - ;; Parallel build fails because of a failed dependency,
> - ;; https://bugzilla.gnome.org/show_bug.cgi?id=732274
> - (lambda _
> - (substitute* "src/services/name/Makefile.am"
> - (("orbit_name_server_2_DEPENDENCIES = \\$(DEPS)
> CosNaming.h")
> - "orbit_name_server_2_DEPENDENCIES = \
> + (list
> + ;; The "timeout-server" test hangs when run in parallel.
> + #:parallel-tests? #f
> + #:configure-flags
> + #~'(;; We don't need static libraries, plus they don't build
> reproducibly
> + ;; (non-deterministic ordering of .o files in the
> archive.)
> + "--disable-static"
> +
> + ;; The programmer kindly gives us a hook to turn off
> deprecation
> + ;; warnings ...
> + "DISABLE_DEPRECATED_CFLAGS=-
> DGLIB_DISABLE_DEPRECATION_WARNINGS")
> + ;; ... which they then completly ignore !!
> + #:phases
> + #~(modify-phases %standard-phases
> + (add-after 'unpack 'fix-parallel-build
> + ;; Parallel build fails because of a failed dependency,
> + ;; https://bugzilla.gnome.org/show_bug.cgi?id=732274
> + (lambda _
> + (substitute* "src/services/name/Makefile.am"
> + (("orbit_name_server_2_DEPENDENCIES = \\$(DEPS)
> CosNaming.h")
> + "orbit_name_server_2_DEPENDENCIES = \
> $(DEPS) CosNaming.h libname-server-2.a"))))
> - (add-before 'configure 'ignore-deprecations
> - (lambda _
> - (substitute* "linc2/src/Makefile.in"
> - (("-DG_DISABLE_DEPRECATED")
> - "-DGLIB_DISABLE_DEPRECATION_WARNINGS")))))))
> + (add-before 'configure 'ignore-deprecations
> + (lambda _
> + (substitute* "linc2/src/Makefile.in"
> + (("-DG_DISABLE_DEPRECATED")
> + "-DGLIB_DISABLE_DEPRECATION_WARNINGS")))))))
What changes in this hunk?
Cheers
next prev parent reply other threads:[~2024-03-08 19:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 17:29 [bug#69652] [PATCH gnome-team 0/1] What should we do with orbit2? Vivien Kraus via Guix-patches via
2024-03-08 17:20 ` [bug#69652] [PATCH gnome-team 1/1] gnu: orbit2: Mark it unsupported in 32-bits systems Vivien Kraus via Guix-patches via
2024-03-08 19:11 ` Liliana Marie Prikler [this message]
2024-03-08 20:03 ` Vivien Kraus via Guix-patches via
2024-03-09 6:36 ` Liliana Marie Prikler
2024-03-09 8:47 ` [bug#69652] [PATCH gnome-team v2 0/3] FIX that damn orbit2 Vivien Kraus via Guix-patches via
2024-03-09 7:48 ` [bug#69652] [PATCH gnome-team v2 1/3] gnu: orbit2: Update style Vivien Kraus via Guix-patches via
2024-03-09 7:52 ` [bug#69652] [PATCH gnome-team v2 2/3] gnu: orbit2: Propagate inputs Vivien Kraus via Guix-patches via
2024-03-09 8:43 ` [bug#69652] [PATCH gnome-team v2 3/3] gnu: orbit2: Fix bug on 32-bit systems Vivien Kraus via Guix-patches via
2024-03-09 17:50 ` [bug#69652] [PATCH gnome-team v2 0/3] FIX that damn orbit2 Maxim Cournoyer
2024-03-09 18:40 ` bug#69652: " Liliana Marie Prikler
2024-03-09 15:57 ` [bug#69652] [PATCH gnome-team 0/1] What should we do with orbit2? Aaron Covrig via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21fccba3ffea43414af7d8d441e03689ad41474b.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=69652@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=rg@raghavgururajan.name \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.