all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jean-Pierre De Jesus DIAZ via Guix-patches via <guix-patches@gnu.org>
To: 67623@debbugs.gnu.org
Cc: Jean-Pierre De Jesus DIAZ <jean@foundationdevices.com>,
	Andreas Enge <andreas@enge.fr>,
	Efraim Flashner <efraim@flashner.co.il>,
	Eric Bavier <bavier@posteo.net>
Subject: [bug#67623] [PATCH 0/3 gnome-team]: Require zlib in gdk-3.0.pc.
Date: Mon,  4 Dec 2023 14:36:56 +0100	[thread overview]
Message-ID: <20231204133657.3448-1-jean@foundationdevices.com> (raw)

This fixes the gtk+ package to correctly depend on zlib on the
pkg-config file as right now it specifies it as -lz but pkg-config is
not able to find the library directory of zlib because it is not listed.

This changes it so that zlib appears in the requires field.

This in turns fixes the coq-ide package build which wasn't able to find
zlib for that reason, and also simplifies the frama-c package which
worked around this by just adding zlib as an input.

I think it's best to use pkg-config way of doing things which simplifies
packages IMO instead of adding zlib to packages that require gtk+ and
don't have zlib listed in inputs.

Additionally moves gtksourceview-3 from native inputs to inputs as it is
a runtime dependency.

Jean-Pierre De Jesus DIAZ (3):
  gnu: gtk+: Require zlib in gdk-3.0.pc.
  gnu: ocaml-lablgtk3-sourceview3: Fix inputs.
  gnu: frama-c: Remove zlib from inputs.

 gnu/packages/gtk.scm   | 13 ++++++++++++-
 gnu/packages/maths.scm |  3 +--
 gnu/packages/ocaml.scm |  2 +-
 3 files changed, 14 insertions(+), 4 deletions(-)

-- 
2.41.0





             reply	other threads:[~2023-12-04 13:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04 13:36 Jean-Pierre De Jesus DIAZ via Guix-patches via [this message]
2023-12-04 13:39 ` [bug#67623] [PATCH 1/3] gnu: gtk+: Require zlib in gdk-3.0.pc Jean-Pierre De Jesus DIAZ via Guix-patches via
2023-12-04 19:32   ` Liliana Marie Prikler
2024-01-03 19:50     ` [bug#67623] [PATCH 0/3 gnome-team]: " Maxim Cournoyer
2024-01-03 22:34       ` Jean-Pierre De Jesus Diaz via Guix-patches via
2024-01-04 20:12         ` Liliana Marie Prikler
2024-01-05 16:43           ` Jean-Pierre De Jesus Diaz via Guix-patches via
2023-12-04 13:39 ` [bug#67623] [PATCH 2/3] gnu: ocaml-lablgtk3-sourceview3: Fix inputs Jean-Pierre De Jesus DIAZ via Guix-patches via
2023-12-04 13:39 ` [bug#67623] [PATCH 3/3] gnu: frama-c: Remove zlib from inputs Jean-Pierre De Jesus DIAZ via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231204133657.3448-1-jean@foundationdevices.com \
    --to=guix-patches@gnu.org \
    --cc=67623@debbugs.gnu.org \
    --cc=andreas@enge.fr \
    --cc=bavier@posteo.net \
    --cc=efraim@flashner.co.il \
    --cc=jean@foundationdevices.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.