From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: 62802@debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: [bug#62802] [PATCH 2/4] services: syslog: Add a reload action.
Date: Wed, 12 Apr 2023 21:24:05 -0400 [thread overview]
Message-ID: <20230413012408.2759-2-maxim.cournoyer@gmail.com> (raw)
In-Reply-To: <20230413012408.2759-1-maxim.cournoyer@gmail.com>
* gnu/services/base.scm (syslog-service-type) [actions]: Add a reload action.
* doc/guix.texi (Base Services): Document it.
---
doc/guix.texi | 12 ++++++++++++
gnu/services/base.scm | 16 +++++++++++++++-
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/doc/guix.texi b/doc/guix.texi
index acb6f0c2e1..70909917a5 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -18573,6 +18573,18 @@ Type of the service that runs the syslog daemon, whose value is a
@code{<syslog-configuration>} object.
@end defvar
+To have a modified @code{syslog-configuration} come into effect after
+reconfiguring your system, the @samp{reload} action should be preferred
+to restarting the service, as many services such as the login manager
+depend on it and would be restarted as well:
+
+@example
+# herd reload syslog
+@end example
+
+which will cause the running @command{syslogd} process to reload its
+configuration.
+
@deftp {Data Type} syslog-configuration
Data type representing the configuration of the syslog daemon.
diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index 1ed874aa84..db7a0bbc56 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1543,7 +1543,21 @@ (define config-file
(documentation "Run the syslog daemon (syslogd).")
(provision '(syslogd))
(requirement '(user-processes))
- (actions (list (shepherd-configuration-action syslog.conf)))
+ (actions
+ (list (shepherd-configuration-action syslog.conf)
+ (shepherd-action
+ (name 'reload)
+ (documentation "Reload the configuration file from disk.")
+ (procedure
+ #~(lambda (pid)
+ (if pid
+ (begin
+ (kill pid SIGHUP)
+ (display #$(G_ "Service syslog has been asked to \
+reload its settings file.")))
+ (display #$(G_ "Service syslog is not running."))))))))
+ ;; Note: a static file name is used for syslog.conf so that the reload
+ ;; action work as intended.
(start #~(let ((spawn (make-forkexec-constructor
(list #$(syslog-configuration-syslogd config)
#$(string-append "--rcfile=" syslog.conf))
--
2.39.2
next prev parent reply other threads:[~2023-04-13 1:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 1:15 [bug#62802] [PATCH 0/4] Add reload action to syslog service Maxim Cournoyer
2023-04-13 1:24 ` [bug#62802] [PATCH 1/4] services: syslog: Move configuration to /etc/syslog.conf Maxim Cournoyer
2023-04-13 1:24 ` Maxim Cournoyer [this message]
2023-04-13 1:24 ` [bug#62802] [PATCH 3/4] services/syslog: Strip leading white space indent in syslog.conf Maxim Cournoyer
2023-04-13 1:24 ` [bug#62802] [PATCH 4/4] services: syslog: Log auth.info to /var/log/secure in default configuration Maxim Cournoyer
2023-04-20 15:26 ` [bug#62802] [PATCH 0/4] Add reload action to syslog service Ludovic Courtès
2023-04-21 13:36 ` bug#62802: " Maxim Cournoyer
2023-04-20 15:22 ` [bug#62802] " Ludovic Courtès
2023-04-21 12:50 ` Maxim Cournoyer
2023-04-21 14:03 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413012408.2759-2-maxim.cournoyer@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=62802@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.