From: Julien Lepiller <julien@lepiller.eu>
To: Garek Dyszel <garekdyszel@disroot.org>
Cc: 57540@debbugs.gnu.org
Subject: [bug#57540] [PATCH] Add ocaml-elpi (a dependency of coq-mathcomp-analysis)
Date: Sat, 3 Sep 2022 20:40:35 +0200 [thread overview]
Message-ID: <20220903204035.22e3b372@sybil.lepiller.eu> (raw)
In-Reply-To: <79d544f7d8ba64b631a6f0f1d2ef0b08@disroot.org>
Hi Garek,
thanks for the patches! As I understand it, these patches introduce 8
new packages, but I count only 7 (with this one which didn't make it as
a part of the series). Could you split the last patch, so each new
package has its own patch?
Also, some points in your patches:
For "Don't know about directory test", you can try with an argument:
#:test-target "some-dir". This directory is the directory where tests
are located. If there is no single directory, you can try
#:test-target "."
Descriptions should use our subset of texinfo. Basically, lists should
look like:
@itemize
@item foo
@item bar
@end itemize
and you can use @file, @code, etc as you see fit (to replace markdown's
"`").
Whenever possible, we try not to rely on github tarballs, so it'd be
best to use a git-reference in all your patches :)
In coq-elpi:
> + ;; Remove the useless line
> + ;; "src/META.coq-elpi"
> + ;; in file _CoqProject.
> + ;; It does not affect
> + ;; the success of compliation.
should be "compilation". And then I wonder why you need that at all, if
it doesn't change compilation result?
> + #t))
Please don't use #t at the end of phases anymore.
> + (replace 'check
The gnu-build-system already runs "make test", doesn't it? Why do you
need to replace this phase?
In coq-mathcomp-hierarchy-builder:
> + (replace 'check
Instead of replacing this phase, maybe try #:test-target "test-suite"
> + ;; Makefile.common has no references to tests at all
> + ;; (yet).
If that means that future versions will have tests (for instance if
master has tests), maybe this should say it more explicitely.
Once you fix all this, could you send a v2 series? Thank you!
next prev parent reply other threads:[~2022-09-03 18:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 1:44 [bug#57540] [PATCH] Add ocaml-elpi (a dependency of coq-mathcomp-analysis) Garek Dyszel via Guix-patches via
2022-09-02 15:20 ` [bug#57540] [PATCH 1/6] gnu: Add ocaml-atd Garek Dyszel via Guix-patches via
2022-09-02 15:22 ` [bug#57540] [PATCH 2/6] gnu: Add ocaml-ansiterminal Garek Dyszel via Guix-patches via
2022-09-02 15:23 ` [bug#57540] [PATCH 3/6] gnu: Add coq-elpi Garek Dyszel via Guix-patches via
2022-09-02 15:24 ` [bug#57540] [PATCH 4/6] gnu: Add coq-mathcomp-hierarchy-builder Garek Dyszel via Guix-patches via
2022-09-02 15:24 ` [bug#57540] [PATCH 5/6] gnu: Add coq-mathcomp-finmap Garek Dyszel via Guix-patches via
2022-09-02 15:25 ` [bug#57540] [PATCH 6/6] gnu: Add coq-mathcomp-bigenough and coq-mathcomp-analysis Garek Dyszel via Guix-patches via
2022-09-03 18:40 ` Julien Lepiller [this message]
2022-09-24 13:05 ` [bug#57540] [PATCH] Add ocaml-elpi (a dependency of coq-mathcomp-analysis) Ludovic Courtès
2022-09-24 18:39 ` Julien Lepiller
2022-09-07 18:31 ` [bug#57540] [RFC PATCH v2 01/19] gnu: Add ocaml-elpi Garek Dyszel via Guix-patches via
2022-09-26 16:52 ` [bug#57540] [PATCH] Please rebase (was: Add ocaml-elpi (a dependency of coq-mathcomp-analysis)) zimoun
2022-09-27 13:04 ` Garek Dyszel via Guix-patches via
2022-09-29 17:13 ` Garek Dyszel via Guix-patches via
2022-09-29 17:39 ` Julien Lepiller
2022-09-30 15:02 ` bug#57540: Splitting into several packages instead Garek Dyszel via Guix-patches via
2022-09-30 15:02 ` [bug#57540] [PATCH] Please rebase (was: Add ocaml-elpi (a dependency of coq-mathcomp-analysis)) Garek Dyszel via Guix-patches via
2022-09-30 12:06 ` zimoun
2022-10-02 20:52 ` Garek Dyszel via Guix-patches via
2022-10-02 22:22 ` zimoun
2022-09-07 18:32 ` [bug#57540] [RFC PATCH v2 02/19] gnu: Add ocaml-atd.* gnu/packages/ocaml.scm (ocaml-atd): New variable Garek Dyszel via Guix-patches via
2022-09-07 18:33 ` [bug#57540] [RFC PATCH v2 03/19] gnu: Add ocaml-ansiterminal.* gnu/packages/ocaml.scm (ocaml-ansiterminal): " Garek Dyszel via Guix-patches via
2022-09-07 18:33 ` [bug#57540] [RFC PATCH v2 04/19] gnu: Add coq-elpi.* gnu/packages/coq.scm (coq-elpi): " Garek Dyszel via Guix-patches via
2022-09-07 18:33 ` [bug#57540] [RFC PATCH v2 05/19] gnu: Add coq-mathcomp-hierarchy-builder.* gnu/packages/coq.scm (coq-mathcomp-hierarchy-builder): " Garek Dyszel via Guix-patches via
2022-09-07 18:33 ` [bug#57540] [RFC PATCH v2 06/19] gnu: Add coq-mathcomp-finmap.* gnu/packages/coq.scm (coq-mathcomp-finmap): " Garek Dyszel via Guix-patches via
2022-09-07 18:33 ` [bug#57540] [RFC PATCH v2 07/19] gnu: Add coq-mathcomp-bigenough.* gnu/packages/coq.scm (coq-mathcomp-bigenough): " Garek Dyszel via Guix-patches via
2022-09-07 18:33 ` [bug#57540] [RFC PATCH v2 08/19] gnu: Add coq-mathcomp-analysis.* gnu/packages/coq.scm (coq-mathcomp-analysis): " Garek Dyszel via Guix-patches via
2022-09-07 18:33 ` [bug#57540] [RFC PATCH v2 09/19] gnu: Add python-version.* gnu/packages/python-xyz.scm (python-version): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 10/19] gnu: Add python-hatchling.* gnu/packages/python-xyz.scm (python-hatchling): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 11/19] gnu: Add python-hatch-vcs.* gnu/packages/python-xyz.scm (python-hatch-vcs): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 12/19] gnu: Add python-hatch-fancy-pypi-readme.* gnu/packages/python-xyz.scm (python-hatch-fancy-pypi-readme): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 13/19] gnu: Add python-pprintpp.* gnu/packages/python-xyz.scm (python-pprintpp): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 14/19] gnu: Add python-icdiff.* gnu/packages/python-xyz.scm (python-icdiff): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 15/19] gnu: Add python-pytest-icdiff.* gnu/packages/python-check.scm (python-pytest-icdiff): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 16/19] gnu: Add python-editables.* gnu/packages/python-build.scm (python-editables): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 17/19] gnu: Add python-pluggy-1.0.* gnu/packages/python-xyz.scm (python-pluggy-1.0): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 18/19] gnu: Add python-setuptools-scm-7.* gnu/packages/python.xyz.scm (python-setuptools-scm-7): " Garek Dyszel via Guix-patches via
2022-09-07 18:34 ` [bug#57540] [RFC PATCH v2 19/19] gnu: Add python-jsonschema-4.15.* gnu/packages/python-xyz.scm (python-jsonschema-4.15): " Garek Dyszel via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220903204035.22e3b372@sybil.lepiller.eu \
--to=julien@lepiller.eu \
--cc=57540@debbugs.gnu.org \
--cc=garekdyszel@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.