From: "Ludovic Courtès" <ludo@gnu.org>
To: 55499@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>, "Ricardo Wurmus" <rekado@elephly.net>
Subject: bug#55499: [PATCH 0/3] Make 'manifest' files more compact
Date: Tue, 31 May 2022 18:09:13 +0200 [thread overview]
Message-ID: <20220531160916.21508-1-ludo@gnu.org> (raw)
In-Reply-To: <87sfp7kkim.fsf@elephly.net>
Hello,
These patches implement what you suggested on IRC: not repeating
entire manifest entries and their propagated inputs. This has a
dramatic impact on the size of the ‘manifest’ file and on the memory
and processing time to read it for the the use case you gave.
The second patch goes a tiny bit further by making the ‘search-paths’
and ‘propagated-inputs’ fields optional, shaving another ~10% on the
size of ‘manifest’ in this example.
The second patch should be squashed with the first one (so we don’t
bump version formats a second time and duplicate code). It’s kinda
optional because it doesn’t bring much compared to the first patch and
causes a bit of extra complexity, but maybe it’s still worth keeping?
Could you try this on your larger use cases and tell me how it goes?
Thanks,
Ludo’.
Ludovic Courtès (3):
tests: Augment profile collision test.
profiles: Do not repeat entries in 'manifest' file.
squash! profiles: Make all entry fields optional.
guix/build/profiles.scm | 32 ++++++++--
guix/profiles.scm | 137 ++++++++++++++++++++++++++++++++--------
tests/profiles.scm | 52 ++++++++++++++-
3 files changed, 187 insertions(+), 34 deletions(-)
base-commit: fed51b26141548a5bae349a5e1d8d6f681320f4f
--
2.36.1
next prev parent reply other threads:[~2022-05-31 16:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 13:53 bug#55499: excessively large manifests due to propagation Ricardo Wurmus
2022-05-24 15:30 ` Ludovic Courtès
2022-05-25 4:35 ` Ricardo Wurmus
2022-05-31 16:09 ` Ludovic Courtès [this message]
2022-05-31 16:09 ` bug#55499: [PATCH 1/3] tests: Augment profile collision test Ludovic Courtès
2022-05-31 16:09 ` bug#55499: [PATCH 2/3] profiles: Do not repeat entries in 'manifest' file Ludovic Courtès
2022-05-31 17:35 ` Maxime Devos
2022-06-01 9:38 ` Ludovic Courtès
2022-05-31 16:09 ` bug#55499: [PATCH 3/3] squash! profiles: Make all entry fields optional Ludovic Courtès
2022-06-14 7:06 ` bug#55499: excessively large manifests due to propagation Ludovic Courtès
2022-07-01 21:54 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531160916.21508-1-ludo@gnu.org \
--to=ludo@gnu.org \
--cc=55499@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.