all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Paul A. Patience" <paul@apatience.com>
To: 54869@debbugs.gnu.org
Cc: "Paul A. Patience" <paul@apatience.com>
Subject: [bug#54869] [PATCH v2 4/7] gnu: python-vedo: Honor #:tests? flag.
Date: Fri, 22 Apr 2022 11:53:17 +0000	[thread overview]
Message-ID: <20220422115258.63649-5-paul@apatience.com> (raw)
In-Reply-To: <20220422115258.63649-1-paul@apatience.com>

* gnu/packages/python-science.scm (python-vedo)[arguments]: Adjust
custom 'check' phase to honor the #:tests? flag. Also remove its
trailing boolean.
---
 gnu/packages/python-science.scm | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/gnu/packages/python-science.scm b/gnu/packages/python-science.scm
index 07d713e013..4538904b68 100644
--- a/gnu/packages/python-science.scm
+++ b/gnu/packages/python-science.scm
@@ -876,15 +876,15 @@ (define-public python-vedo
          (add-after 'build 'mpi-setup
            ,%openmpi-setup)
          (replace 'check
-           (lambda* (#:key inputs outputs #:allow-other-keys)
-             (setenv "HOME" (getcwd))
-             (add-installed-pythonpath inputs outputs)
-             (with-directory-excursion "tests"
-               (for-each (lambda (dir)
-                           (with-directory-excursion dir
-                             (invoke "./run_all.sh")))
-                         '("common" "dolfin")))
-             #t)))))
+           (lambda* (#:key tests? inputs outputs #:allow-other-keys)
+             (when tests?
+               (setenv "HOME" (getcwd))
+               (add-installed-pythonpath inputs outputs)
+               (with-directory-excursion "tests"
+                 (for-each (lambda (dir)
+                             (with-directory-excursion dir
+                               (invoke "./run_all.sh")))
+                           '("common" "dolfin")))))))))
     (inputs        ; for the check phase
      `(("dolfin" ,fenics)
        ("pkgconfig" ,python-pkgconfig)
--
2.35.1






  parent reply	other threads:[~2022-04-22 12:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12  1:21 [bug#54869] [PATCH 0/5] gnu: python-vedo: Update to 2022.2.0 and sanity-check failures Paul A. Patience
2022-04-12  1:22 ` [bug#54870] [PATCH 1/5] gnu: fenics-dolfin: Honor #:tests? flag Paul A. Patience
2022-04-12  1:22 ` [bug#54871] [PATCH 2/5] gnu: fenics: " Paul A. Patience
2022-04-12  1:22 ` [bug#54872] [PATCH 3/5] gnu: python-vedo: " Paul A. Patience
2022-04-12  1:22 ` [bug#54874] [PATCH 4/5] gnu: python-vedo: Remove input labels Paul A. Patience
2022-04-12  1:22 ` [bug#54873] [PATCH 5/5] gnu: python-vedo: Update to 2022.2.0 Paul A. Patience
2022-04-22 11:53 ` [bug#54869] [PATCH v2 0/7] " Paul A. Patience
2022-04-22 11:53   ` [bug#54869] [PATCH v2 1/7] gnu: fenics-dolfin: Honor #:tests? flag Paul A. Patience
2022-04-22 17:46     ` Maxime Devos
2022-04-22 11:53   ` [bug#54869] [PATCH v2 2/7] gnu: fenics: " Paul A. Patience
2022-04-22 11:53   ` [bug#54869] [PATCH v2 3/7] gnu: fenics: Fix sanity check Paul A. Patience
2022-04-22 11:53   ` Paul A. Patience [this message]
2022-04-22 11:53   ` [bug#54869] [PATCH v2 5/7] gnu: python-vedo: Remove input labels Paul A. Patience
2022-04-22 11:53   ` [bug#54869] [PATCH v2 6/7] gnu: python-vedo: Disable sanity check Paul A. Patience
2022-04-22 11:53   ` [bug#54869] [PATCH v2 7/7] gnu: python-vedo: Update to 2022.2.0 Paul A. Patience
2022-04-22 20:25 ` [bug#54869] [PATCH v3 0/7] " Paul A. Patience
2022-04-22 20:25   ` [bug#54869] [PATCH v3 1/7] gnu: fenics-dolfin: Honor #:tests? flag Paul A. Patience
2022-04-22 20:25   ` [bug#54869] [PATCH v3 2/7] gnu: fenics: " Paul A. Patience
2022-04-22 20:25   ` [bug#54869] [PATCH v3 3/7] gnu: fenics: Fix sanity check Paul A. Patience
2022-04-22 20:25   ` [bug#54869] [PATCH v3 4/7] gnu: python-vedo: Honor #:tests? flag Paul A. Patience
2022-04-22 20:25   ` [bug#54869] [PATCH v3 5/7] gnu: python-vedo: Remove input labels Paul A. Patience
2022-04-22 20:26   ` [bug#54869] [PATCH v3 6/7] gnu: python-vedo: Disable sanity check Paul A. Patience
2022-04-22 20:26   ` [bug#54869] [PATCH v3 7/7] gnu: python-vedo: Update to 2022.2.0 Paul A. Patience
2022-05-06 13:11   ` bug#54869: bug#54874: [PATCH 4/5] gnu: python-vedo: Remove input labels Ludovic Courtès
2022-05-06 13:36     ` [bug#54869] [bug#54874] " Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220422115258.63649-5-paul@apatience.com \
    --to=paul@apatience.com \
    --cc=54869@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.